? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
26 Jan 2020

the class .dropdown-menu in _header.scss is repeated with conflicting values. This Pr combines the two classes. There will be no visible difference to the display of the dropdown mnu as this is just removing code which is over ridden.

PR for #27639

The class is used for the user menu
image

Dont forget npm i or node build.js --compile-css

avatar brianteeman brianteeman - open - 26 Jan 2020
avatar brianteeman brianteeman - change - 26 Jan 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Jan 2020
Category Administration Templates (admin)
avatar richard67 richard67 - test_item - 26 Jan 2020 - Tested successfully
avatar richard67
richard67 - comment - 26 Jan 2020

I have tested this item successfully on d961505

Code review + visual test + element inspection in developer tools: All fine. Min-width is 18rem, z-index is 1060.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27661.

avatar richard67
richard67 - comment - 26 Jan 2020

P.S.: And no conflicts shown in element inspection in developer tools for that element, while without this PR there are some.

avatar Quy Quy - test_item - 26 Jan 2020 - Tested successfully
avatar Quy
Quy - comment - 26 Jan 2020

I have tested this item successfully on d961505


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27661.

avatar Quy Quy - change - 26 Jan 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 26 Jan 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27661.

avatar Quy Quy - change - 26 Jan 2020
Labels Added: ?
avatar Quy Quy - change - 26 Jan 2020
Labels Added: ?
avatar Quy Quy - change - 26 Jan 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-01-26 19:33:29
Closed_By Quy
avatar Quy Quy - close - 26 Jan 2020
avatar Quy Quy - merge - 26 Jan 2020
avatar brianteeman
brianteeman - comment - 26 Jan 2020

thanks

Add a Comment

Login with GitHub to post a comment