? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
26 Jan 2020

The code that adds the class "ml-auto" to the Options button on all the toolbars has an extra space. It doesn't break anything but technically its invalid markup.

To test view the source of any Options button in any component before and after this PR.

It will change from
<joomla-toolbar-button class=" ml-auto"> to
<joomla-toolbar-button class="ml-auto">

avatar brianteeman brianteeman - open - 26 Jan 2020
avatar brianteeman brianteeman - change - 26 Jan 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Jan 2020
Category Layout
avatar ChristineWk ChristineWk - test_item - 26 Jan 2020 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 26 Jan 2020

I have tested this item successfully on aa80075


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27660.

avatar Quy Quy - test_item - 26 Jan 2020 - Tested successfully
avatar Quy
Quy - comment - 26 Jan 2020

I have tested this item successfully on aa80075


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27660.

avatar Quy Quy - change - 26 Jan 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 26 Jan 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27660.

avatar Quy Quy - change - 26 Jan 2020
Labels Added: ?
avatar Quy Quy - change - 26 Jan 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-01-26 18:51:12
Closed_By Quy
Labels Added: ?
avatar Quy Quy - close - 26 Jan 2020
avatar Quy Quy - merge - 26 Jan 2020
avatar brianteeman
brianteeman - comment - 26 Jan 2020

Thx

Add a Comment

Login with GitHub to post a comment