Joomla! Issue Tracker | Joomla! CMS #27638 - [4.0] Empty catch statement

? ?

Fixed in Code Base
3 Feb 2020
Medium
Build: 4.0-dev
# 27638
Diff
brianteeman:drupal_sprint_weekend6

Pending

Pending Hound Hound is busy sniffing around... Details

User tests: Successful: Unsuccessful:

brianteeman
25 Jan 2020

My ide is telling me that it is bad to have an empty catch statement and if there is one then it should have a comment. Following the example of @roland-d @mbabker and others I added a comment

1b25730 25 Jan 2020

[4.0] Empty catch statement

brianteeman - open - 25 Jan 2020

brianteeman - change - 25 Jan 2020

Status

New

⇒

Pending

joomla-cms-bot - change - 25 Jan 2020

Category

⇒

Libraries

Quy - test_item - 25 Jan 2020 - Tested successfully

Quy - comment - 25 Jan 2020

I have tested this item ✅ successfully on 1b25730

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27638.}

richard67 - test_item - 26 Jan 2020 - Tested successfully

richard67 - comment - 26 Jan 2020

I have tested this item ✅ successfully on 1b25730

Code review.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27638.}

richard67 - change - 26 Jan 2020

Status

Pending

⇒

Ready to Commit

richard67 - comment - 26 Jan 2020

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27638.}

richard67 - change - 26 Jan 2020

Labels

Added: ? ?

45e4a29 29 Jan 2020

Merge branch '4.0-dev' into drupal_sprint_weekend6

Quy - change - 29 Jan 2020

Labels

b404462 3 Feb 2020

Merge branch '4.0-dev' into drupal_sprint_weekend6

rdeutz - close - 3 Feb 2020

rdeutz - merge - 3 Feb 2020

rdeutz - change - 3 Feb 2020

Status	Ready to Commit	⇒	Fixed in Code Base
Closed_Date	0000-00-00 00:00:00	⇒	2020-02-03 22:08:36
Closed_By		⇒	rdeutz

brianteeman - comment - 3 Feb 2020

Thanks

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#27638] - [4.0] Empty catch statement

Add a Comment