NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
25 Jan 2020

The value of 0 works without specifying units in all situations where numbers with length units or percentages are allowed. There is no difference between 0px, 0em, 0%, or any other zero-value. The units aren't important because the value is still zero. CSS allows you to omit the length units for zero values and still remain valid CSS.

avatar brianteeman brianteeman - open - 25 Jan 2020
avatar brianteeman brianteeman - change - 25 Jan 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Jan 2020
Category Repository NPM Change Front End Templates (site)
84387a3 25 Jan 2020 avatar brianteeman more
avatar brianteeman brianteeman - change - 25 Jan 2020
Labels Added: NPM Resource Changed ?
avatar joomla-cms-bot joomla-cms-bot - change - 25 Jan 2020
Category Repository NPM Change Front End Templates (site) Administration Templates (admin) Repository NPM Change Front End Templates (site)
avatar Quy Quy - test_item - 25 Jan 2020 - Tested successfully
avatar Quy
Quy - comment - 25 Jan 2020

I have tested this item successfully on 2a290fe


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27637.

avatar jwaisner
jwaisner - comment - 26 Jan 2020

@brianteeman is this a code review or are testers needed?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27637.

avatar brianteeman
brianteeman - comment - 26 Jan 2020

as it works the same with the unit and without then its just a code review

avatar Quy Quy - change - 31 Jan 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-01-31 19:58:48
Closed_By Quy
avatar Quy Quy - close - 31 Jan 2020
avatar Quy Quy - merge - 31 Jan 2020

Add a Comment

Login with GitHub to post a comment