? ? ? Pending

User tests: Successful: Unsuccessful:

avatar astridx
astridx
23 Jan 2020

Pull Request for Issue #27490.

Summary of Changes

Because CPanel has unreadable fields in some windows sizes I changed the two column view to a one column view

Testing Instructions

  1. Open Global Configuration an see that all options displayed in two columns.
  2. Apply this patch
  3. Open Global Configuration again and see, that the options displayed in one column.

Expected result

Global Configuration   test   Administration

Actual result

Global Configuration   test   Administration(1)

Documentation Changes Required

No

2bdc3af 23 Jan 2020 avatar astridx wip
avatar astridx astridx - open - 23 Jan 2020
avatar astridx astridx - change - 23 Jan 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Jan 2020
Category Layout
avatar astridx astridx - change - 23 Jan 2020
Title
wip
[4.0] CPanel Option in one column
avatar astridx astridx - edited - 23 Jan 2020
avatar richard67 richard67 - test_item - 23 Jan 2020 - Tested successfully
avatar richard67
richard67 - comment - 23 Jan 2020

I have tested this item successfully on 2bdc3af

PR does what it claims to do, so I give it a good test.

If the result is nice or not might be a matter of taste. At least it is better than before regarding readability of the drop down options.

I hope other people will give feedback, too.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27613.

avatar jwaisner jwaisner - test_item - 23 Jan 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 23 Jan 2020

I have tested this item successfully on 2bdc3af


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27613.

avatar Quy
Quy - comment - 23 Jan 2020

Yes, much better, however, on phone, the label needs to be above the input.

27613

Maybe this can be addressed in #27558.

avatar astridx
astridx - comment - 23 Jan 2020

@Quy Your are right. I made a separate PR for this in case that it could not be addressed in #27558: See: #27615

avatar Quy Quy - change - 23 Jan 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 23 Jan 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27613.

avatar infograf768 infograf768 - change - 24 Jan 2020
Labels Added: ?
avatar wilsonge
wilsonge - comment - 24 Jan 2020

Rather than this maybe change to column-count-lg-2 column-count-md-1

avatar astridx
astridx - comment - 24 Jan 2020

Rather than this maybe change to column-count-lg-2 column-count-md-1

lg is ≥992px, right?
The problem exists with 1400px:
#27490 (comment)

So I would like to leave it that way.

avatar astridx astridx - change - 24 Jan 2020
Labels Added: ? ?
avatar astridx
astridx - comment - 24 Jan 2020

I have now deleted the class.

avatar Quy Quy - test_item - 24 Jan 2020 - Tested successfully
avatar Quy
Quy - comment - 24 Jan 2020

I have tested this item successfully on c057244


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27613.

avatar richard67 richard67 - test_item - 24 Jan 2020 - Tested successfully
avatar richard67
richard67 - comment - 24 Jan 2020

I have tested this item successfully on c057244


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27613.

avatar wilsonge wilsonge - close - 24 Jan 2020
avatar wilsonge wilsonge - merge - 24 Jan 2020
avatar wilsonge wilsonge - change - 24 Jan 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-01-24 21:27:29
Closed_By wilsonge
avatar wilsonge
wilsonge - comment - 24 Jan 2020

Thanks!

avatar wilsonge
wilsonge - comment - 24 Jan 2020

Thanks!

Add a Comment

Login with GitHub to post a comment