Feeling Lucky
?
[#27612] - [4.0] Multiple Select lists
- Closed
- 6 Feb 2020
- Medium
- Build: staging
- # 27612
I made a PR #25335 that makes sure that we are using the joomla.form.field.list-fancy-select layout when we have a multiple select list field.
@wilsonge closed it in the mistaken belief that you can do multiselects natively in the browser. Well you can do them but they look like hell as shown below.
Before
After
joomla-cms-bot
- | Labels |
Added:
?
|
||
richard67
- | Status | New | ⇒ | Confirmed |
wilsonge
- comment
- 6 Feb 2020
I can't because it says it's been force pushed/recreated since it was closed
wilsonge
- comment
- 6 Feb 2020
Tbh I'm really reluctant to reintroduce this everywhere. I want it still class based please. Not global select applying like we made the mistake with chosen
brianteeman
- comment
- 6 Feb 2020
ok I will make a new PR
Can you still check that PR as I believe the approach there is correct
wilsonge
- comment
- 6 Feb 2020
Ahh yes should be fine. sorry i should have re-reviewed before commenting rubbish
brianteeman
- comment
- 6 Feb 2020
yes you should ;)
| Status | Confirmed | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-06 23:43:55 |
| Closed_By | ⇒ | brianteeman |
I agree @brianteeman. It looks much cleaner in the proposed change.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27612.