Feeling Lucky
?
?
[#27554] - [4.0] tooltip text alignment
- Fixed in Code Base
- 18 Jan 2020
- Medium
- Build: 4.0-dev
- # 27554
- Diff
- brianteeman:ttft1
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Simple PR adds clarity and improves readability
dont forget npm i
example on smart search
before
after
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
jwaisner
- comment
- 17 Jan 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27554.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
SharkyKZ
- comment
- 17 Jan 2020
RTC.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27554.
Quy
- comment
- 17 Jan 2020
For RTL, it should be right-aligned.
| Status | Ready to Commit | ⇒ | Pending |
infograf768
- comment
- 17 Jan 2020
Back to pending until rtl is taken care of to avoid another pr for mini stuff
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27554.
infograf768
- comment
- 18 Jan 2020
Suggestion:
[...]
z-index: $zindex-tooltip;
[dir=ltr] & {
text-align: left;
}
[dir=rtl] & {
text-align: right;
}
brianteeman
- comment
- 18 Jan 2020
Thanks. I will update soon
brianteeman
- comment
- 18 Jan 2020
updated for rtl
| Status | Pending | ⇒ | Ready to Commit |
infograf768
- comment
- 18 Jan 2020
As change is obvious, setting rtc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27554.
| Labels |
Added:
?
|
||
brianteeman
- comment
- 18 Jan 2020
Done it - its hard to check this sort of thing from my phone
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-01-18 14:28:18 |
| Closed_By | ⇒ | wilsonge |
wilsonge
- comment
- 18 Jan 2020
Thanks!
brianteeman
- comment
- 18 Jan 2020
Thanks
I have tested this item✅ successfully on f792bff
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27554.