?
avatar brianteeman
brianteeman
17 Jan 2020

Since the change in global configuration to use True/False instead of 1/0 the display of the system information missing some important information

image

Basically anything with a value of false doesnt display anything

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
3.00

avatar brianteeman brianteeman - open - 17 Jan 2020
avatar joomla-cms-bot joomla-cms-bot - change - 17 Jan 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 17 Jan 2020
avatar jwaisner
jwaisner - comment - 17 Jan 2020

Confirmed.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27553.

avatar infograf768
infograf768 - comment - 18 Jan 2020

Maybe we could do

diff --git a/administrator/components/com_admin/tmpl/sysinfo/default_config.php b/administrator/components/com_admin/tmpl/sysinfo/default_config.php
index 16f0764..6796ac7 100644
--- a/administrator/components/com_admin/tmpl/sysinfo/default_config.php
+++ b/administrator/components/com_admin/tmpl/sysinfo/default_config.php
@@ -36,4 +36,5 @@
 					</th>
 					<td>
+						<?php $value === false ? $value = Text::_('JNO') : $value; ?>
 						<?php echo htmlspecialchars($value, ENT_QUOTES); ?>
 					</td>

(Text::_('JNO') can be replaced by '0') but I was also thinking that we could go further and also add
<?php $value === 1 || $value === true ? $value = Text::_('JYES') : $value; ?>

To get a readable value.

avatar mbabker
mbabker - comment - 18 Jan 2020

I’d almost say it should print true/false over Yes/No so it matches the value in the config file. Basically if (is_bool($foo)) { echo $foo === true ? 'true' : 'false'; }.

avatar Quy Quy - change - 21 Jan 2020
Status New Closed
Closed_Date 0000-00-00 00:00:00 2020-01-21 17:18:39
Closed_By Quy
avatar Quy
Quy - comment - 21 Jan 2020

Please test PR #27588

avatar Quy Quy - close - 21 Jan 2020

Add a Comment

Login with GitHub to post a comment