[#27520] - [4.0] Update Tinymce
- Fixed in Code Base
- 5 Feb 2020
- Medium
- Build: 4.0-dev
- # 27520
- Diff
- brianteeman:saturday13
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
TinyMce follows semantic versioning. There is no reason that we should be locked down to an old patch release of 5.0.14 when the current is 5.1.5
Some help fixing the javascript in build\build-modules-js\init.es6.js to write the correct version number in the plugin xml would be appreciated
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | NPM Change Front End Plugins |
| Labels |
Added:
NPM Resource Changed
?
|
||
Thanks. I will test and merge in the morning.
| Category | NPM Change Front End Plugins | ⇒ | JavaScript Repository NPM Change Front End Plugins |
It's because regex for replacing version expects a valid version in XML. As a quick fix you can manually change the version just in the XML to something valid (e.g. back to 5.0.14) and then run npm install again.
Although I don't see the need for such specific regex. We could simplify it. See brianteeman#91.
@brianteeman During testing everything works as expected, just need to confirm that the version presented in the extension manager will still be 5.0.14 or should that show 5.1.5?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27520.
It will probably show 5.0.14. You can use Refresh Cache button to update data from manifest.
@brianteeman You still need to commit XML changes to correct version.
Refreshing the Cache worked. I noticed the version shows as "^5.1.0". Is that supposed to have the "^" in the version number? Changing <version>^5.1.0</version> to <version>5.1.0</version> corrects this. I dont fully understand the versioning in Tinymce, so this may be normal.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27520.
Can someone please check and merge this as it addresses a security vulnerability
You still need to run npm install to update the XML with correct version.
Can someone please check and merge this as it addresses a security vulnerability
rdeutz
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-05 17:43:34 |
| Closed_By | ⇒ | rdeutz |
Thanks
I have tested this item✅ successfully on b620847
Tested all functions of Tinymce on backend and frontend. Everything works as intended.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27520.