? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
14 Jan 2020

Summary of Changes

Renames Joomla\Component\Contact\Site\Helper\Route and Joomla\Component\Newsfeeds\Site\Helper\Route to be consistent with other helper classes.

Testing Instructions

Create some contacts and newsfeeds.
View them in frontend.
Run Smart Search indexer.

Expected result

Works like before.

Documentation Changes Required

IDK.

avatar SharkyKZ SharkyKZ - open - 14 Jan 2020
avatar SharkyKZ SharkyKZ - change - 14 Jan 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Jan 2020
Category Administration com_contact com_newsfeeds Front End Plugins
avatar SharkyKZ SharkyKZ - change - 14 Jan 2020
Title
[4.0] Rename Contact Newsfeeds route helpers
[4.0] Rename Contact and Newsfeeds route helpers
avatar SharkyKZ SharkyKZ - edited - 14 Jan 2020
avatar jwaisner jwaisner - test_item - 14 Jan 2020 - Tested unsuccessfully
avatar jwaisner
jwaisner - comment - 14 Jan 2020

I have tested this item ? unsuccessfully on 592ba35

When creating a contact I get "An error has occurred.

0 Class 'Joomla\Component\Contact\Site\Helper\RouteHelper' not found "

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27510.
avatar jwaisner
jwaisner - comment - 14 Jan 2020

27510

NOTE: The contact is created when you navigate back to the contacts.

avatar SharkyKZ
SharkyKZ - comment - 14 Jan 2020

Looks like the patch hasn't been applied correctly. Can you check if Route.php file in components/com_contact/Helper/ has been renamed to RouteHelper.php correctly?

avatar brianteeman brianteeman - test_item - 14 Jan 2020 - Tested successfully
avatar brianteeman
brianteeman - comment - 14 Jan 2020

I have tested this item successfully on 592ba35

seems to work fine for me - cannot replicate the error reported by @jwaisner


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27510.

avatar jwaisner jwaisner - test_item - 14 Jan 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 14 Jan 2020

I have tested this item successfully on 592ba35

Apparently something went weird when I went to patch. After patching, everything works as expected.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27510.

avatar Quy Quy - change - 14 Jan 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 14 Jan 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27510.

avatar wilsonge wilsonge - change - 15 Jan 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-01-15 00:45:50
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 15 Jan 2020
avatar wilsonge wilsonge - merge - 15 Jan 2020
avatar wilsonge
wilsonge - comment - 15 Jan 2020

Thanks!

Add a Comment

Login with GitHub to post a comment