? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
13 Jan 2020

Fixes the margin on the permissions pages for components etc not for individual items.
dont forget npm i

There is more to do on this page for RTL but thats for another day

before

image

after

image

avatar brianteeman brianteeman - open - 13 Jan 2020
avatar brianteeman brianteeman - change - 13 Jan 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Jan 2020
Category Administration Templates (admin)
avatar brianteeman brianteeman - change - 13 Jan 2020
The description was changed
avatar brianteeman brianteeman - edited - 13 Jan 2020
avatar Quy Quy - test_item - 13 Jan 2020 - Tested successfully
avatar Quy
Quy - comment - 13 Jan 2020

I have tested this item successfully on 32b1d4c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27506.

avatar infograf768
infograf768 - comment - 13 Jan 2020

I suggest to add a specific dir=ltr for the margin-left

avatar brianteeman
brianteeman - comment - 13 Jan 2020

There is no need

avatar infograf768
infograf768 - comment - 13 Jan 2020

It is always better to do that as otherwise you would need to do a mergin-left: auto to make sure nothing wrong happens, also we have to check mobile view.

avatar jwaisner jwaisner - test_item - 14 Jan 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 14 Jan 2020

I have tested this item successfully on 32b1d4c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27506.

avatar infograf768 infograf768 - change - 14 Jan 2020
Labels Added: ?
avatar infograf768
infograf768 - comment - 14 Jan 2020

This solves indeed what the PR is for.
As stated, there are other aspects remaining in ltr as well as rtl.
Mobile is anyway quite useless as the groups will always show below the permissions (which is not the case in J3). Will merge as soon as drone is fine.

avatar infograf768 infograf768 - change - 14 Jan 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-01-14 07:30:48
Closed_By infograf768
avatar infograf768 infograf768 - close - 14 Jan 2020
avatar infograf768 infograf768 - merge - 14 Jan 2020
avatar infograf768
infograf768 - comment - 14 Jan 2020

tks

avatar brianteeman
brianteeman - comment - 14 Jan 2020

Thanks - one issue at a time

Add a Comment

Login with GitHub to post a comment