? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
13 Jan 2020

Fixes the media field on RTL displays

dont forget npm i

before

image

after

image

avatar brianteeman brianteeman - open - 13 Jan 2020
avatar brianteeman brianteeman - change - 13 Jan 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Jan 2020
Category Administration Templates (admin)
avatar Quy Quy - test_item - 13 Jan 2020 - Tested successfully
avatar Quy
Quy - comment - 13 Jan 2020

I have tested this item successfully on 1cae004


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27505.

avatar infograf768 infograf768 - change - 14 Jan 2020
Labels Added: ?
avatar infograf768
infograf768 - comment - 14 Jan 2020

I think we need more and same issue in LTR/RTL

In administrator/templates/atum/scss/blocks/_global.scss line 149
We have

 //Multiple buttons wrapping
.input-group input {
  min-width: 220px;
}

This should be deleted, otherwise, depending on the modal width, we get for a modal

Screen Shot 2020-01-14 at 09 04 15

and when reducing window width when for example editing an article

Screen Shot 2020-01-14 at 09 08 21

After deleting that class

Screen Shot 2020-01-14 at 09 09 03

I had a fast look at other places in core where we have .input-group input and deletion looks like it has no unwanted impact.
The correction can be done in this PR (easier) or in a specific PR.

avatar brianteeman
brianteeman - comment - 14 Jan 2020

@infograf768 that change was added by you here #27128

avatar infograf768
infograf768 - comment - 14 Jan 2020

It looks like that had unwanted consequences...
We could solve it by not deleting that class (to keep associations displaying OK in mobile view and be eventually useful as @ciar4n said in #27128) but adding a new one specific to the image field.

#images .input-group input {
  min-width: 0;
}

This works here.

avatar ciar4n
ciar4n - comment - 14 Jan 2020

This should be deleted, otherwise, depending on the modal width, we get for a modal

What is the problem here? Is it that the buttons wrap? In that instance, I would consider it acceptable behavior as the alternative is an unreadable input field. Fix the layout of the form, not the field.

avatar brianteeman
brianteeman - comment - 14 Jan 2020

I bow to the opinion of the designer

avatar infograf768
infograf768 - comment - 15 Jan 2020

@ciar4n
Ooops, I forgot that the field may be filled by the image path...

avatar infograf768 infograf768 - test_item - 15 Jan 2020 - Tested successfully
avatar infograf768
infograf768 - comment - 15 Jan 2020

I have tested this item successfully on bf62cf9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27505.

avatar infograf768 infograf768 - change - 15 Jan 2020
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 15 Jan 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27505.

avatar infograf768 infograf768 - change - 15 Jan 2020
Labels Added: ?
avatar HLeithner HLeithner - change - 15 Jan 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-01-15 08:59:05
Closed_By HLeithner
avatar HLeithner HLeithner - close - 15 Jan 2020
avatar HLeithner HLeithner - merge - 15 Jan 2020
avatar HLeithner
HLeithner - comment - 15 Jan 2020

Thanks

avatar brianteeman
brianteeman - comment - 15 Jan 2020

thanks

Add a Comment

Login with GitHub to post a comment