Feeling Lucky
?
?
[#27485] - [3.10] Make sure notices in updater does not lead to unknown error
- Fixed in Code Base
- 19 Jan 2020
- Medium
- Build: 3.10-dev
- # 27485
- Diff
- zero-24:unknown_error
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #17849
Summary of Changes
In this PR: #17849 this else statement has been added without beeing used. In some cases this can lead to an notice when $this->currentUpdate->php_minimum; is not set.
Testing Instructions
- Install 3.10-dev
- install com_patchtester
- apply this patch: #27410
- point the update server to https://update.joomla.org/core/nightlies/next_major_list.xml
- notice the
unknown errormessage for the patchtester update
Expected result
No
Actual result
unknown error
Documentation Changes Required
none
Additional Infos
Yes I know that com_patchtester has an update for Joomla 4.0 but this has been marked as beta update the pre-update checker does not support that right now.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
jwaisner
- comment
- 19 Jan 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27485.
Quy
- comment
- 19 Jan 2020
RTC
| Status | Pending | ⇒ | Ready to Commit |
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-01-19 08:25:08 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
?
|
||
HLeithner
- comment
- 19 Jan 2020
Thanks
I have tested this item✅ successfully on d2425c6
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27485.