User tests: Successful: Unsuccessful:
Pull Request for Issue #27438
all credits to @dawe78
see #27462
use []
Connect to a MSSQL database using sqlsrv-driver; database name contains dots: database.v.3.2.4
connect to database server, select database
Error message "Could not connect to SQL Server database."
Status | New | ⇒ | Pending |
Category | ⇒ | MS SQL Libraries |
Labels |
Added:
?
|
Thanks guys!
Can you please test this?
I'm sorry, I'm very busy at the moment... I tested it yesterday and it works perfect!
@dawe78 Could you mark your test result in the issue tracker? Just go to https://issues.joomla.org/tracker/joomla-cms/27484 and use the "Test this" button at the top left corner. Then select the appropriate test result (success) and submitt. Thanks in advance.
I have tested this item
Wasn't SQL Server support going to be dropped in Joomla 4?
Ref. https://docs.joomla.org/Potential_backward_compatibility_issues_in_Joomla_4
Question is if we should have the same change for other db types in J4.
I remember I have seen database names with dots in past in an industrial environment, too.
So it seems to be not so exotic.
mysql does not allow dots
mysql does not allow dots
I see, that's right. So nothing to do for this in J4.
We should add it to the frame work https://github.com/joomla-framework/database/blob/2.0-dev/src/Sqlsrv/SqlsrvDriver.php#L137
Thanks for the framework pr
merged in the framework not in the staging ?
let's close it
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-12 19:27:19 |
Closed_By | ⇒ | alikon |
As always we need tests...
@HLeithner We have 1 good test by the one who made the issue. Will be hard to get a 2nd tester for MS SQL Server. I suggest to reopen and merge by review.
that's why i'm closing
i wish you good luck on finding 2 mssql user's that test this
sorry i've decided to clean my backlog
it is not a template issues ... so who cares
So a second can't be too hard ;)
we have already 1 good test
anyway you can find some payed contributor to do this silly work
Thanks guys!