? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
11 Jan 2020

Pull Request for Issue #27438
all credits to @dawe78
see #27462

Summary of Changes

use []

Testing Instructions

Connect to a MSSQL database using sqlsrv-driver; database name contains dots: database.v.3.2.4

Expected result

connect to database server, select database

Actual result

Error message "Could not connect to SQL Server database."

avatar alikon alikon - open - 11 Jan 2020
avatar alikon alikon - change - 11 Jan 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Jan 2020
Category MS SQL Libraries
avatar alikon alikon - change - 12 Jan 2020
Labels Added: ?
avatar dawe78
dawe78 - comment - 14 Jan 2020

Thanks guys!

avatar HLeithner
HLeithner - comment - 14 Jan 2020

Thanks guys!

Can you please test this?

avatar richard67
richard67 - comment - 15 Jan 2020

@dawe78 Could you test this PR? I would test, but I can't because I don't have MS SQL Server available. We don't have many people using MS SQL Server and so have problems to find testers for it.

avatar dawe78
dawe78 - comment - 16 Jan 2020

I'm sorry, I'm very busy at the moment... I tested it yesterday and it works perfect!

avatar richard67 richard67 - alter_testresult - 16 Jan 2020 - dawe78: Tested successfully
avatar richard67 richard67 - alter_testresult - 16 Jan 2020 - dawe78: Not tested
avatar richard67
richard67 - comment - 16 Jan 2020

@dawe78 Could you mark your test result in the issue tracker? Just go to https://issues.joomla.org/tracker/joomla-cms/27484 and use the "Test this" button at the top left corner. Then select the appropriate test result (success) and submitt. Thanks in advance.

avatar dawe78 dawe78 - test_item - 16 Jan 2020 - Tested successfully
avatar dawe78
dawe78 - comment - 16 Jan 2020

I have tested this item successfully on e6ef380


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27484.

avatar toivo
toivo - comment - 17 Jan 2020

Wasn't SQL Server support going to be dropped in Joomla 4?

Ref. https://docs.joomla.org/Potential_backward_compatibility_issues_in_Joomla_4

avatar SharkyKZ
SharkyKZ - comment - 17 Jan 2020

@toivo That's correct. But this patch is for 3.x which still accepts bug fixes.

avatar richard67
richard67 - comment - 17 Jan 2020

Question is if we should have the same change for other db types in J4.

I remember I have seen database names with dots in past in an industrial environment, too.

So it seems to be not so exotic.

avatar brianteeman
brianteeman - comment - 17 Jan 2020

mysql does not allow dots

avatar richard67
richard67 - comment - 17 Jan 2020

mysql does not allow dots

I see, that's right. So nothing to do for this in J4.

avatar alikon
alikon - comment - 19 Jan 2020
avatar HLeithner
HLeithner - comment - 19 Jan 2020

Thanks for the framework pr

avatar alikon
alikon - comment - 12 Feb 2020

merged in the framework not in the staging ?
let's close it

avatar alikon alikon - close - 12 Feb 2020
avatar alikon alikon - change - 12 Feb 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-02-12 19:27:19
Closed_By alikon
avatar HLeithner
HLeithner - comment - 12 Feb 2020

As always we need tests...

avatar richard67
richard67 - comment - 12 Feb 2020

@HLeithner We have 1 good test by the one who made the issue. Will be hard to get a 2nd tester for MS SQL Server. I suggest to reopen and merge by review.

avatar alikon
alikon - comment - 12 Feb 2020

that's why i'm closing
i wish you good luck on finding 2 mssql user's that test this

avatar richard67
richard67 - comment - 12 Feb 2020

@alikon In opposite to J4, in J3 we don't fetch regularly the package from the framework, so it should be fixed here too.

avatar alikon
alikon - comment - 12 Feb 2020

sorry i've decided to clean my backlog
it is not a template issues ... so who cares

avatar HLeithner
HLeithner - comment - 12 Feb 2020

So a second can't be too hard ;)

avatar richard67
richard67 - comment - 12 Feb 2020

we have already 1 good test

avatar alikon
alikon - comment - 12 Feb 2020

anyway you can find some payed contributor to do this silly work
?

Add a Comment

Login with GitHub to post a comment