? ? Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
11 Jan 2020

Summary of Changes

Remove jQuery and boostrap.js dependencies for a templates.
Partial redo of #23742, that lost somewhere while waiting for #25775

Testing Instructions

Apply patch, and make sure all still works.

Expected result

Works

Actual result

Works

Documentation Changes Required

nope

avatar Fedik Fedik - open - 11 Jan 2020
avatar Fedik Fedik - change - 11 Jan 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Jan 2020
Category Administration Templates (admin) Front End Templates (site)
avatar richard67
richard67 - comment - 11 Jan 2020

@Fedik I've just tested as described and everything works. The only thing which confuses me a bit is that if I am in backend or in frontend (but in frontend only after having logged in) I can see in network analysis of browser development tools that jquery.min.js and bootstrap.bundle.min.js are still loaded. Is that expected? If yes, I'll give a good test result. Just let me know.

Update: Or does it need some special action after having applied the patch e.g. with patchtester?

avatar Fedik
Fedik - comment - 11 Jan 2020

The jquery.min.js and bootstrap.bundle.min.js still may be loaded, because they requested by other components, layouts etc.

The main idea in the patch is that the template does not require these scripts to work, so they should not be set as dependency.
You can find some more details in #23742

avatar richard67
richard67 - comment - 11 Jan 2020

@Fedik Yes, I had already checked #23742 . I just have asked because I wanted to be sure all is right.

avatar richard67 richard67 - test_item - 11 Jan 2020 - Tested successfully
avatar richard67
richard67 - comment - 11 Jan 2020

I have tested this item successfully on 3917a77

All works as well as before after having applied the patch and watching browser console errors and php error logs while checking all.

In addition, the backend and frontend templates don't load bootstrap and jquery anymore when not being logged in.

Only after login when some component requires that, they are loaded.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27473.

avatar richard67
richard67 - comment - 11 Jan 2020

And to make it complete: Drone failure as usual seems not to be related to this PR.

avatar SharkyKZ
SharkyKZ - comment - 11 Jan 2020

This breaks menu in frontend. See similar PR #23744.

avatar richard67
richard67 - comment - 11 Jan 2020

@SharkyKZ Am just testing again but can't see what's broken. Could you provide some details?

avatar SharkyKZ
SharkyKZ - comment - 11 Jan 2020

The menu toggle button on small screens doesn't work:

Screen Shot 2020-01-11 at 13 39 03

avatar Fedik
Fedik - comment - 11 Jan 2020

@SharkyKZ it seems on mobile version, I did not noticed,
Thanks, I will check

avatar richard67
richard67 - comment - 11 Jan 2020

Ouch, didn't notice that.

avatar richard67 richard67 - test_item - 11 Jan 2020 - Not tested
avatar richard67
richard67 - comment - 11 Jan 2020

I have not tested this item.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27473.

avatar Fedik Fedik - change - 11 Jan 2020
Labels Added: ?
avatar Fedik
Fedik - comment - 11 Jan 2020

Okay I have add bootstrap.js back to cassiopeia, it seems the mobile menu use "navbar-toggler" feature.
Should work now.

avatar richard67 richard67 - test_item - 11 Jan 2020 - Tested successfully
avatar richard67
richard67 - comment - 11 Jan 2020

I have tested this item successfully on d7df7b4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27473.

avatar jwaisner jwaisner - test_item - 11 Jan 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 11 Jan 2020

I have tested this item successfully on d7df7b4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27473.

avatar richard67 richard67 - change - 11 Jan 2020
The description was changed
Status Pending Ready to Commit
avatar joomla-cms-bot joomla-cms-bot - edited - 11 Jan 2020
avatar richard67
richard67 - comment - 11 Jan 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27473.

avatar dgrammatiko
dgrammatiko - comment - 11 Jan 2020

Thank you @Fedik ?

avatar wilsonge wilsonge - close - 15 Jan 2020
avatar wilsonge wilsonge - merge - 15 Jan 2020
avatar wilsonge wilsonge - change - 15 Jan 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-01-15 18:06:45
Closed_By wilsonge
Labels Added: ?
avatar wilsonge
wilsonge - comment - 15 Jan 2020

Thanks!

avatar Quy
Quy - comment - 16 Jan 2020

It is no longer possible to tab between Set 2, Set 1, and Set 0 in the TinyMCE plugin.

avatar Fedik
Fedik - comment - 17 Jan 2020

need to load bootstrap in that specific layout

avatar dgrammatiko
dgrammatiko - comment - 17 Jan 2020

Or use the custom elements tabs as the rest of the backend?

avatar Fedik
Fedik - comment - 17 Jan 2020

when it will stop mess with DOM ?

avatar dgrammatiko
dgrammatiko - comment - 17 Jan 2020

When will it adhere to the standards for CE? (I have no answer for both questions, it seems both issues are due to my bad implementation)

avatar richard67
richard67 - comment - 17 Jan 2020

It is no longer possible to tab between Set 2, Set 1, and Set 0 in the TinyMCE plugin.

@Quy Seems I've missed that when testing, shame on me.

Will someone make a new issue for that, or even a new PR?

avatar Fedik
Fedik - comment - 17 Jan 2020

@richard67 I will do PR, but some time later, maybe on the weekend

avatar Fedik
Fedik - comment - 18 Jan 2020

@richard67 @Quy please test this one #27560

Add a Comment

Login with GitHub to post a comment