User tests: Successful: Unsuccessful:
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Templates (admin) Front End Templates (site) |
The jquery.min.js and bootstrap.bundle.min.js still may be loaded, because they requested by other components, layouts etc.
The main idea in the patch is that the template does not require these scripts to work, so they should not be set as dependency.
You can find some more details in #23742
I have tested this item
All works as well as before after having applied the patch and watching browser console errors and php error logs while checking all.
In addition, the backend and frontend templates don't load bootstrap and jquery anymore when not being logged in.
Only after login when some component requires that, they are loaded.
And to make it complete: Drone failure as usual seems not to be related to this PR.
Ouch, didn't notice that.
I have not tested this item.
Labels |
Added:
?
|
Okay I have add bootstrap.js back to cassiopeia, it seems the mobile menu use "navbar-toggler" feature.
Should work now.
I have tested this item
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-01-15 18:06:45 |
Closed_By | ⇒ | wilsonge | |
Labels |
Added:
?
|
Thanks!
It is no longer possible to tab between Set 2, Set 1, and Set 0 in the TinyMCE plugin.
need to load bootstrap in that specific layout
Or use the custom elements tabs as the rest of the backend?
when it will stop mess with DOM
When will it adhere to the standards for CE? (I have no answer for both questions, it seems both issues are due to my bad implementation)
@richard67 I will do PR, but some time later, maybe on the weekend
@richard67 @Quy please test this one #27560
@Fedik I've just tested as described and everything works. The only thing which confuses me a bit is that if I am in backend or in frontend (but in frontend only after having logged in) I can see in network analysis of browser development tools that jquery.min.js and bootstrap.bundle.min.js are still loaded. Is that expected? If yes, I'll give a good test result. Just let me know.
Update: Or does it need some special action after having applied the patch e.g. with patchtester?