NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
9 Jan 2020

This is a replacement PR for #23609 which resolves the merge conflicts

To test

npm i

Go the module assignment tab of any menu item
Click on the name of a module
A modal will open
Change the published state of the modal and save and close
Check that the module is now shown with the changed state
Check that there are no js errors in the console

avatar brianteeman brianteeman - open - 9 Jan 2020
avatar brianteeman brianteeman - change - 9 Jan 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Jan 2020
Category JavaScript Repository NPM Change
a6b9d2f 9 Jan 2020 avatar brianteeman cs
avatar brianteeman brianteeman - change - 9 Jan 2020
Labels Added: NPM Resource Changed ?
avatar jwaisner jwaisner - test_item - 11 Jan 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 11 Jan 2020

I have tested this item successfully on a6b9d2f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27455.

avatar jwaisner jwaisner - test_item - 11 Jan 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 11 Jan 2020

I have tested this item successfully on 0aa0894


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27455.

avatar infograf768 infograf768 - test_item - 12 Jan 2020 - Tested successfully
avatar infograf768
infograf768 - comment - 12 Jan 2020

I have tested this item successfully on 0aa0894


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27455.

avatar infograf768 infograf768 - change - 12 Jan 2020
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 12 Jan 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27455.

avatar infograf768 infograf768 - change - 12 Jan 2020
Labels Added: ?
avatar infograf768
infograf768 - comment - 12 Jan 2020

Please also look at #27491

avatar infograf768 infograf768 - change - 12 Jan 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-01-12 09:00:01
Closed_By infograf768
avatar infograf768 infograf768 - close - 12 Jan 2020
avatar infograf768 infograf768 - merge - 12 Jan 2020
avatar infograf768
infograf768 - comment - 12 Jan 2020

tks

avatar infograf768
infograf768 - comment - 12 Jan 2020

Will now make PR for #27491

avatar infograf768
infograf768 - comment - 12 Jan 2020

Please test #27492

Add a Comment

Login with GitHub to post a comment