? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
6 Jan 2020

Now that the code has been fixed with #27412 I can update the strings to be more meaningful.

The strings for Screen Readers are now "Show Password" and "Hide Password"

Testing Instructions

Make sure you are the current codebase (ie you have #27412)

Apply this PR

Update the javascript with
npm i

Inspect the password field in the admin user manager, admin login, site login

The strings for Screen Readers are now "Show Password" and "Hide Password"

avatar brianteeman brianteeman - open - 6 Jan 2020
avatar brianteeman brianteeman - change - 6 Jan 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Jan 2020
Category Administration Language & Strings Modules JavaScript Repository NPM Change Layout Front End
avatar Quy Quy - test_item - 6 Jan 2020 - Tested successfully
avatar Quy
Quy - comment - 6 Jan 2020

I have tested this item successfully on 6220a78


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27425.

avatar jwaisner jwaisner - test_item - 7 Jan 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 7 Jan 2020

I have tested this item successfully on 6220a78


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27425.

avatar Quy Quy - change - 7 Jan 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 7 Jan 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27425.

avatar wilsonge wilsonge - change - 7 Jan 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-01-07 10:26:08
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge wilsonge - close - 7 Jan 2020
avatar wilsonge wilsonge - merge - 7 Jan 2020
avatar wilsonge
wilsonge - comment - 7 Jan 2020

Thanks!

avatar brianteeman
brianteeman - comment - 7 Jan 2020

w00t

Add a Comment

Login with GitHub to post a comment