NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
6 Jan 2020

Summary of Changes

This will move searchtools styling to the template files.
More info in #27384 comments.

Testing Instructions

Apply patch, run npm install

Expected result

All works

Actual result

Almost works, with some rtl issue

@infograf768 please check

avatar Fedik Fedik - open - 6 Jan 2020
avatar Fedik Fedik - change - 6 Jan 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Jan 2020
Category Administration Templates (admin) JavaScript Repository NPM Change Libraries
avatar infograf768
infograf768 - comment - 6 Jan 2020

Let's go for it.
We can correct some more stuff after merge.
Some are in _toolbar.scss

@wilsonge @HLeithner

avatar infograf768 infograf768 - test_item - 6 Jan 2020 - Tested successfully
avatar infograf768
infograf768 - comment - 6 Jan 2020

I have tested this item successfully on 789eabc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27416.

avatar jwaisner jwaisner - test_item - 6 Jan 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 6 Jan 2020

I have tested this item successfully on 789eabc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27416.

avatar SharkyKZ SharkyKZ - change - 6 Jan 2020
Status Pending Ready to Commit
Labels Added: ? NPM Resource Changed
avatar SharkyKZ
SharkyKZ - comment - 6 Jan 2020

RTC.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27416.

avatar HLeithner HLeithner - change - 6 Jan 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-01-06 22:30:21
Closed_By HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 6 Jan 2020
avatar HLeithner HLeithner - merge - 6 Jan 2020
avatar HLeithner
HLeithner - comment - 6 Jan 2020

Thanks

avatar infograf768
infograf768 - comment - 7 Jan 2020

@Fedik
To help figure any remaining issue in RTL, what have you remarked? (Please use screenshot)
To be sure, first please patch with #27384

avatar Fedik
Fedik - comment - 7 Jan 2020

@infograf768 it looks good to me:
LTR:
screen 2020-01-07 11 10 00 1560x281

RTL:
screen 2020-01-07 11 14 15 1570x283

avatar infograf768
infograf768 - comment - 7 Jan 2020

Thanks. Remains therefore after #27384 is merged, some aspects from toolbar css dealing with margins in mobile view (rtl/ltr).
Will look at these later.

avatar infograf768
infograf768 - comment - 9 Jan 2020

See #27443 for follow-up

Add a Comment

Login with GitHub to post a comment