User tests: Successful: Unsuccessful:
Pull Request for Issue #27319 .
This Pull Request (PR) extends the pre-update checker for extensions in the Joomla Update Component so it can handle extension set XML files (i.e. update sites of type "collection"), too.
Not sure if this is the most elegant way to fix the issue, but I've tried to do it with little impact on existing code.
https://update.joomla.org/core/nightlies/next_major_list.xml
.https://www.jah-tz.de/downloads/extensions/juep/update.xml
- this is an extension set XML, and the type of the update site is "collection" (not visible in the Update Sites view in backend but in database and in the extensions's XML file plugins/system/updateemail/updateemail.xml
).http://www.jah-tz.de/downloads/extensions/juep/sts/update.xml
- this is a "normal" (i.e. not extension set) XML, and the type of the update site is "extension" (not visible in the Update Sites view in backend but in database and in the extensions's XML file plugins/system/updateemail/updateemail.xml
).location
of the #__update_sites
table to https://test5.richard-fath.de/test-pr27410_update.xml
. This will make it point to a modified extension set xml file so that the target platform version of the extension's current version is 4.0, and this points then to an update XML also having a target platform version of 4.0 for the extension's current version.location
of the #__update_sites
table to https://test5.richard-fath.de/test-pr27410_update_2.xml
. This will make it point to a modified extension set xml file so that the target platform version of an available update for the extension is 4.0, and this points then to an update XML also having a target platform version of 4.0.location
of the #__update_sites
table to like it was at the beginning, i.e. https://www.jah-tz.de/downloads/extensions/juep/update.xml
.location
of the #__update_sites
table to https://test5.richard-fath.de/test-pr27410_update-sts.xml
This is a modified "normal" update xml with an available target platform version 4.0 for the extension's current version.location
of the #__update_sites
table to https://test5.richard-fath.de/test-pr27410_update-sts_2.xml
This is a modified "normal" update xml with an available target platform version 4.0 for an available update for the extension.Case 1. For an extension with installed version not compatible to 4.0 and no compatible update available:
Case 2. For an extension with installed version compatible to 4.0:
Case 3. For an extension with installed version not compatible to 4.0 but a compatible update available:
In all cases: The pre-update checker can handle extension set update servers. The PHP log doesn't show the warning mentioned in section "Actual result" below. For "normal" (i.e. not extension set) update servers everything works with this PR as well as without it.
The pre-update checker can not handle extension set update servers:
In PHP log: PHP Warning: Creating default object from empty value in /home/richard/lamp/public_html/joomla-cms-3.10-dev/libraries/src/Updater/Update.php on line 297
The pre-update checker currently doesn't care if an update site is enabled or not, it uses it anyway for the checks. This PR here doesn't change that.
I don't know if this is intended or if it's a bug. If it's a bug, a new issue should be opened and/or a new PR should be made.
None.
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_joomlaupdate |
Labels |
Added:
?
|
Title |
|
Labels |
Added:
?
|
I have tested this item
works good to me thanks @richard67
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Thanks for testing.
Labels |
Added:
?
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-01-21 11:44:09 |
Closed_By | ⇒ | wilsonge |
Thanks!
Thanks, too.
Added the "Release Blocker" lables because the issue solved by this PR has that label, too.