[#27409] - [4.0] Append button ML-2 (RTL)
- Fixed in Code Base
- 6 Jan 2020
- Medium
- Build: 4.0-dev
- # 27409
- Diff
- brianteeman:append_rtl
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
We had an override for MR-2 (margin right) but not for ML-2 (margin left)
This can be seen on the admin login screen
Before LTR
Before RTL
After LTR
After RTL
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27409.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27409.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-01-06 03:25:43 |
| Closed_By | ⇒ | Quy |
@brianteeman @Quy
This has created an issue as ml-2 is not only used for the login.
ml-2 is used instead of mr-2 for RTL in chromes/well.php
$margin = Factory::getLanguage()->isRtl() ? ' ml-2' : ' mr-2';
Therefore
margin-left: 0 !important; is wrong as we get
instead of
Maybe we should change $margin in well.php to
$margin = ' mr-2';
or delete that line and use directly
$headerIcon = '<span class="' . htmlspecialchars($params->get('header_icon')) . ' mr-2" aria-hidden="true"></span>';
What do you think?
NOTE:
Also I remark that a lot of classes are NOT present in installation template-rtl.scss to override those in template.scss, including a ml-2...
This has never been tested. It is a release blocker. Will create an issue.
A possible solution could be to import atum/scss/template-rtl.scss, but not sure.
ML-2 and MR-2 are utility classes and their values in the RTL css are now correct. If there are now other issues being observed as a result of correcting those utility classes the problem is in the other classes not in these
As I demonstrated, #27409 (comment), classes are not concerned in this case.
We have to modify the chrome.
Will make a PR.
I have tested this item✅ successfully on 3c2017e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27409.