NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
31 Dec 2019

Pull Request for Issue #27149 .

Summary of Changes

Fix batchSelector is undefined.

Testing Instructions

Go to Global Configuration > System.
Enable Debug System.
Create a new custom field.
View fields list.
Enable browser's web developer.
View console for error.

Apply PR.
Run npm i.

Actual result

TypeError: batchSelector is undefined batch-language.js:43:7

avatar Quy Quy - open - 31 Dec 2019
avatar Quy Quy - change - 31 Dec 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Dec 2019
Category JavaScript Repository NPM Change
avatar richard67
richard67 - comment - 31 Dec 2019

@Quy I can't reproduce the issue with the instructions above. What am I missing?

avatar Quy Quy - change - 31 Dec 2019
The description was changed
avatar Quy Quy - edited - 31 Dec 2019
avatar Quy
Quy - comment - 31 Dec 2019

So you are unable to reproduce it before applying the PR? Here is a screenshot.

27390

avatar richard67
richard67 - comment - 31 Dec 2019

So you are unable to reproduce it before applying the PR?

@Quy Yes, was testing with Article fields, too, and did not have the type error.

avatar richard67
richard67 - comment - 31 Dec 2019

@Quy Now I did exactly the same as you, i.e. I gave the field the title "Text". Now I can reproduce. Strange.

avatar richard67 richard67 - test_item - 31 Dec 2019 - Tested successfully
avatar richard67
richard67 - comment - 31 Dec 2019

I have tested this item successfully on aa3adec


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27390.

avatar richard67
richard67 - comment - 31 Dec 2019

Any idea why api tests fail in drone? Looks like the usual randomly occurring timeout to me, but I'm not sure.

avatar alikon alikon - test_item - 1 Jan 2020 - Tested successfully
avatar alikon
alikon - comment - 1 Jan 2020

I have tested this item successfully on aa3adec


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27390.

avatar alikon alikon - change - 1 Jan 2020
Status Pending Ready to Commit
avatar alikon
alikon - comment - 1 Jan 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27390.

avatar HLeithner HLeithner - change - 1 Jan 2020
Labels Added: ?
avatar HLeithner HLeithner - change - 2 Jan 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-01-02 11:34:11
Closed_By HLeithner
Labels Added: NPM Resource Changed ?
avatar HLeithner HLeithner - close - 2 Jan 2020
avatar HLeithner HLeithner - merge - 2 Jan 2020
avatar HLeithner
HLeithner - comment - 2 Jan 2020

Thanks

Add a Comment

Login with GitHub to post a comment