[#27374] - clarification of the return value for the user ID
- Fixed in Code Base
- 29 Feb 2020
- Medium
- Build: staging
- # 27374
- Diff
- tecpromotion:patch-3
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
To make it clear what the returned number is. It is the user ID. There was some confusion about this in the German language files, and some site operators asked for the unit and thought it was days.
With this change, the username is returned as suggested and the super user is notified.
Testing Instructions
.
Expected result
.
Actual result
.
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings |
Would it not be better to keep the language string the same and to change the id to username
| Title |
|
||||||
Would it not be better to keep the language string the same and to change the id to username
I've been thinking about that, too. Especially because we (almost) always use the user name in the action logs.
Would it not be better to keep the language string the same and to change the id to username
I've been thinking about that, too. Especially because we (almost) always use the user name in the action logs.
Agree.
$messageModel->notifySuperUsers(
JText::_('PLG_SYSTEM_PRIVACYCONSENT_NOTIFICATION_USER_PRIVACY_EXPIRED_SUBJECT'),
JText::sprintf(
'PLG_SYSTEM_PRIVACYCONSENT_NOTIFICATION_USER_PRIVACY_EXPIRED_MESSAGE',
JFactory::getUser($user->user_id)->username
)
);This should do the trick. cc @tecpromotion
| Labels |
Added:
?
?
?
|
||
| Category | Administration Language & Strings | ⇒ | Front End Plugins |
| Labels |
Removed:
?
|
||
@brianteeman I have withdrawn the adjustment of the language string and as suggested committed the username as return value. Many thanks to @zero-24 and @richard67
| Labels |
Removed:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27374.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27374.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27374.
Merging + cc for @imanickam @infograf768 to check whether this can / should / need to be communicated to the TT's
Thanks @tecpromotion
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-29 11:36:27 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 00955a9
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27374.