? Pending

User tests: Successful: Unsuccessful:

avatar pjdevries
pjdevries
29 Dec 2019

Pull Request for Issue #27372.

Summary of Changes

Change input filter for password in basic api authentication plugin from default 'cmd' to 'string'.

Testing Instructions

Create a user with a password containing spaces.
Send a valid API request, authenticated by the above mentioned user's name and password.

Expected result

200 response

Actual result

200 response

Documentation Changes Required

n/a

avatar pjdevries pjdevries - open - 29 Dec 2019
avatar pjdevries pjdevries - change - 29 Dec 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Dec 2019
Category Unit Tests Repository Administration
avatar richard67
richard67 - comment - 29 Dec 2019

@pjdevries You have to make your PR against the 4.0-dev branch and not the staging branch of the CMS:
pr-wrong-branch

avatar pjdevries
pjdevries - comment - 29 Dec 2019

Thanks for your perception. I rectified my mistake.

avatar richard67
richard67 - comment - 29 Dec 2019

@pjdevries Could you now click the "Update branch" button at the bottom of your PR?

avatar pjdevries pjdevries - change - 29 Dec 2019
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 29 Dec 2019
Category Unit Tests Repository Administration Front End Plugins
avatar pjdevries
pjdevries - comment - 29 Dec 2019

Sorry, sorry, sorry. It's my first PR. Thanx for the kind comments.

avatar richard67
richard67 - comment - 29 Dec 2019

@pjdevries No problem, all ok. Last click on button was just to retrigger the automatic tests because before they had failed. Thanks for your contribution so far.

avatar richard67 richard67 - change - 29 Dec 2019
Build staging 4.0-dev
avatar Quy
Quy - comment - 29 Dec 2019

Please test PR #27245

avatar Quy Quy - change - 29 Dec 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-12-29 15:21:51
Closed_By Quy
Labels Added: ?
Removed: ? ?
avatar Quy Quy - close - 29 Dec 2019

Add a Comment

Login with GitHub to post a comment