?
avatar zero-24
zero-24
19 Dec 2019

Steps to reproduce the issue

While fixing this: #17969 (here: #27318) i noticed that the Pre Update checker can't handle extension set update servers

Expected result

The pre update checker can handle extension set update servers

Actual result

The pre update checker can not handle extension set update servers

Additional comments

The problem is more or less here: https://github.com/joomla/joomla-cms/blob/3.10-dev/administrator/components/com_joomlaupdate/models/default.php#L1518

This method only work correctly with extension update servers (single extension) but not extensionset update servers.

avatar zero-24 zero-24 - open - 19 Dec 2019
avatar joomla-cms-bot joomla-cms-bot - change - 19 Dec 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 19 Dec 2019
avatar zero-24 zero-24 - change - 19 Dec 2019
Labels Added: ?
avatar zero-24 zero-24 - labeled - 19 Dec 2019
avatar zero-24 zero-24 - change - 19 Dec 2019
The description was changed
avatar zero-24 zero-24 - edited - 19 Dec 2019
avatar richard67
richard67 - comment - 20 Dec 2019

@zero-24 Do you have a link to an extensionset update server so we can check and investigate for a possible solution?

avatar zero-24
zero-24 - comment - 20 Dec 2019

You can use this extension as an example: (example: JUEP für Joomla 3.zip)

example updateserver are: https://www.jah-tz.de/downloads/extensions/juep/update.xml

avatar richard67
richard67 - comment - 20 Dec 2019

Thanks, that helps a lot. Is anybody working on it already?

avatar zero-24
zero-24 - comment - 20 Dec 2019

Not that I'm aware of.

avatar joomla-cms-bot joomla-cms-bot - change - 4 Jan 2020
The description was changed
avatar joomla-cms-bot joomla-cms-bot - edited - 4 Jan 2020
avatar richard67
richard67 - comment - 4 Jan 2020

@zero-24 I've updated the link in the description to point to the right line of code due to recently merged changes in the same file. Will seee if I can work on this issue.

avatar richard67 richard67 - change - 4 Jan 2020
The description was changed
avatar joomla-cms-bot joomla-cms-bot - edited - 4 Jan 2020
avatar richard67 richard67 - change - 4 Jan 2020
The description was changed
avatar joomla-cms-bot joomla-cms-bot - edited - 4 Jan 2020
avatar richard67
richard67 - comment - 4 Jan 2020

@zero-24 Important question: The build for this issue is "staging" in the issue tracker. But the link in your description is to the file on the 3.10-dev branch. Shall this be fixed in staging or in 3.10-dev?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27319.

avatar richard67
richard67 - comment - 5 Jan 2020

It seems that not only the pre-update checker has problems with extensionset updates.

When testing with @zero-24 's plugin JUEP.fur.Joomla.3.zip I've modified the version number in xml and database so that an update should be found for this plugin.

The plugin has 2 update sites: One with an extensionset xml and another one (sts) with a "normal" xml.

When the 2nd update site is activated, an update is found, and when it is not activated, no update is found.

When analysing code of the installer I saw that it seems not to handle extensionset update xml file, but in opposite to the pre-update checker the error is avoided by simply not loading the xml if it is not a "normal" one. The only place which I could find where extensionset is checked is in the FoF library, but this seems not to be used anywhere in 3.10 in the installer.

So I'm a bit confused now.

Somewhere extensionset have to be handled correctly for languages and for core updates because the translations update site and the core update site both point to an extensionset xml. But I haven't found the place in code where this is checked (except in the FoF library).

But for extensions extensionset seems not to be supported if my test was right.

Does anybody know more about it? @zero-24 Do you have an idea or know who could have one?

Update: Forget the above. I had to modify the xml files so that there's a target platform version 3.10, then the update was found.

avatar richard67
richard67 - comment - 5 Jan 2020

@zero-24 Meanwhile it is also clear to me that this issue is for 3.10-dev, because on staging we don't have the pre-update check yet. Could you change the branch in the issue tracker from "staging" to "3.10-dev"? I could do that for you, but I don't like very much to modify other people's issues or PRs without having asked them.

avatar richard67
richard67 - comment - 5 Jan 2020

PR #27410 is ready. @zero-24 and others please test.

avatar richard67
richard67 - comment - 5 Jan 2020

Closing as having PR #27410 .

avatar richard67 richard67 - change - 5 Jan 2020
Status New Closed
Closed_Date 0000-00-00 00:00:00 2020-01-05 21:10:39
Closed_By richard67
avatar richard67 richard67 - close - 5 Jan 2020
avatar wilsonge wilsonge - change - 24 Jan 2020
Labels Removed: ?
avatar wilsonge wilsonge - unlabeled - 24 Jan 2020

Add a Comment

Login with GitHub to post a comment