? ? ? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
19 Dec 2019

Pull Request for Issue #17969

Summary of Changes

Dont dublicate extensions with more than one update server

Testing Instructions

  • install extension with more than one update server (example: JUEP für Joomla 3.zip)
  • go to the pre update checker

Expected result

Only on time in the list

Actual result

two times in the list

Documentation Changes Required

none

avatar zero-24 zero-24 - open - 19 Dec 2019
avatar zero-24 zero-24 - change - 19 Dec 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Dec 2019
Category Administration com_joomlaupdate
avatar zero-24 zero-24 - change - 19 Dec 2019
Labels Added: ?
avatar zero-24 zero-24 - change - 19 Dec 2019
The description was changed
avatar zero-24 zero-24 - edited - 19 Dec 2019
avatar zero-24 zero-24 - change - 19 Dec 2019
The description was changed
avatar zero-24 zero-24 - edited - 19 Dec 2019
avatar zero-24
zero-24 - comment - 19 Dec 2019

The unknow error message comes from this issue here: #27319 it is not directly related to the duplication that is fixed here.

avatar zero-24 zero-24 - change - 19 Dec 2019
Labels Added: ?
avatar brianteeman brianteeman - test_item - 20 Dec 2019 - Tested successfully
avatar brianteeman
brianteeman - comment - 20 Dec 2019

I have tested this item successfully on 2921dcd

on the basis of your statement that the "unknown error" is to be expected this PR does what it says and removes the duplicate


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27318.

avatar zero-24
zero-24 - comment - 20 Dec 2019

on the basis of your statement that the "unknown error" is to be expected this PR does what it says and removes the duplicate

Yes the unknown error issue is reported here: #27319 as of today the pre update checker does not support extensionset updateservers. This now fully show the issue.

avatar richard67 richard67 - test_item - 20 Dec 2019 - Tested successfully
avatar richard67
richard67 - comment - 20 Dec 2019

I have tested this item successfully on 2921dcd

Same result: Unknown error shown, but I trust the information that it's a different issue. Duplicates are removed from the list.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27318.

avatar richard67 richard67 - change - 20 Dec 2019
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 20 Dec 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27318.

avatar HLeithner HLeithner - close - 27 Dec 2019
avatar HLeithner HLeithner - merge - 27 Dec 2019
avatar HLeithner HLeithner - change - 27 Dec 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-12-27 15:16:27
Closed_By HLeithner
Labels Added: ?
avatar HLeithner
HLeithner - comment - 27 Dec 2019

Thanks

avatar zero-24 zero-24 - change - 28 Dec 2019
The description was changed
avatar zero-24 zero-24 - edited - 28 Dec 2019

Add a Comment

Login with GitHub to post a comment