Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#27316] - [3.10] Improve pre update checker cs and add a dedicated message when no extensions are found

? ? ? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
19 Dec 2019

Summary of Changes

[3.10] Improve pre update checker cs and add a dedicated message when no extensions are found

Testing Instructions

Expected result

A message that no extensions have been found.

Actual result

Only the notices part of the table with no indication what is happening or what this is reffering to.

Documentation Changes Required

none

avatar zero-24 zero-24 - open - 19 Dec 2019
avatar zero-24 zero-24 - change - 19 Dec 2019
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Dec 2019
Category ⇒ Administration com_joomlaupdate Language & Strings
avatar zero-24 zero-24 - change - 19 Dec 2019
Labels Added: ? ?
avatar brianteeman
brianteeman - comment - 20 Dec 2019

It works but the text looks really "lost"

image

It looks better (I believe) like this

image

The code for that is

		<div class="span6">
			<h3>
				<?php echo JText::_('COM_JOOMLAUPDATE_VIEW_DEFAULT_EXTENSIONS'); ?>
			</h3>
			<div class="alert alert-no-items">
				<?php echo JText::_('COM_JOOMLAUPDATE_VIEW_DEFAULT_EXTENSIONS_NONE'); ?>
			</div>
		</div>
avatar zero-24
zero-24 - comment - 20 Dec 2019

Pushed thanks @brianteeman

avatar brianteeman brianteeman - test_item - 20 Dec 2019 - Tested successfully
avatar brianteeman
brianteeman - comment - 20 Dec 2019

I have tested this item ✅ successfully on e4d64ed

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27316.

avatar richard67 richard67 - test_item - 20 Jan 2020 - Tested successfully
avatar richard67
richard67 - comment - 20 Jan 2020

I have tested this item ✅ successfully on c3bf4b3

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27316.

avatar richard67 richard67 - change - 20 Jan 2020
Status Pending ⇒ Ready to Commit
avatar richard67
richard67 - comment - 20 Jan 2020

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27316.

avatar richard67
richard67 - comment - 20 Jan 2020

Brian's test was still valid because after that was only one small code style change => RTC.

avatar zero-24
zero-24 - comment - 21 Jan 2020

Thanks ?

avatar rdeutz rdeutz - change - 3 Feb 2020
Labels Added: ?
avatar rdeutz rdeutz - close - 3 Feb 2020
avatar rdeutz rdeutz - merge - 3 Feb 2020
avatar rdeutz rdeutz - change - 3 Feb 2020
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-02-03 16:21:08
Closed_By ⇒ rdeutz

Add a Comment

Login with GitHub to post a comment