? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
19 Dec 2019

Summary of Changes

As title says.

Before patch

LTR

Screen Shot 2019-12-19 at 11 43 29

RTL
Screen Shot 2019-12-19 at 11 43 45

After patch

LTR

Screen Shot 2019-12-19 at 11 34 29

RTL

Screen Shot 2019-12-19 at 11 34 52

avatar infograf768 infograf768 - open - 19 Dec 2019
avatar infograf768 infograf768 - change - 19 Dec 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Dec 2019
Category Front End Templates (site)
avatar C-Lodder
C-Lodder - comment - 19 Dec 2019

With the amount of margins that have been tweaked for RTL, I don't know why you don't just create a SCSS mixin

avatar C-Lodder
C-Lodder - comment - 19 Dec 2019

Something I've quickly mocked up if you are interested.

Mixin:

@mixin margin($position, $size) {
  margin-#{$position}: $size;
  
  $rtl-position: null;
  @if $position == 'left' {
    $rtl-position: right;
  } @else if $position == 'right' {
    $rtl-position: left;
  }

  @if $rtl-position != null {
    [dir=rtl] & {
      margin-#{$rtl-position}: $size;
    }
  }
}

Random element class:

.myClass {
  display: block;
  @include margin('left', 2rem);
}

This will add your desired RTL code and ignore top and bottom

avatar infograf768
infograf768 - comment - 20 Dec 2019

@C-Lodder
Sorry, but this kind of code is above my skills.
I can close this if you like and let you propose a new PR.

avatar infograf768 infograf768 - change - 2 Feb 2020
Labels Added: ?
avatar brianteeman
brianteeman - comment - 8 Feb 2020

Closed as we have a new pr

avatar brianteeman brianteeman - change - 8 Feb 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-02-08 23:58:55
Closed_By brianteeman
avatar brianteeman brianteeman - close - 8 Feb 2020

Add a Comment

Login with GitHub to post a comment