NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
14 Dec 2019

Pull Request for Issue #27258 .

The script associations-edit should check for a selected value, not for the article title.

Testing Instructions

Please look #27258 for detail

Note: need to run npm install

avatar Fedik Fedik - open - 14 Dec 2019
avatar Fedik Fedik - change - 14 Dec 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Dec 2019
Category JavaScript Repository NPM Change
avatar Fedik Fedik - change - 14 Dec 2019
The description was changed
avatar Fedik Fedik - edited - 14 Dec 2019
avatar Fedik Fedik - change - 14 Dec 2019
The description was changed
avatar Fedik Fedik - edited - 14 Dec 2019
avatar infograf768
infograf768 - comment - 14 Dec 2019

@Fedik
There was a good reason we switched to name instead of id.
Will try to find the PR concerned tomorrow.

avatar infograf768
infograf768 - comment - 14 Dec 2019

See #25060

avatar Fedik
Fedik - comment - 14 Dec 2019

I see,
but the _name always have a value (even if nothing selected), so it make no sense to use it to detect existsAssociations = true;,
or I missed something, hm

avatar infograf768 infograf768 - change - 15 Dec 2019
Labels Added: NPM Resource Changed ?
avatar infograf768
infograf768 - comment - 15 Dec 2019

Looks like the file has been modified since #25060 . Your PR works fine. thanks.

avatar infograf768 infograf768 - test_item - 15 Dec 2019 - Tested successfully
avatar infograf768
infograf768 - comment - 15 Dec 2019

I have tested this item successfully on a1c9078


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27269.

avatar brianteeman brianteeman - test_item - 18 Dec 2019 - Tested successfully
avatar brianteeman
brianteeman - comment - 18 Dec 2019

I have tested this item successfully on a1c9078

Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27269.

avatar Quy Quy - change - 18 Dec 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 18 Dec 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27269.

avatar Quy Quy - change - 18 Dec 2019
Labels Added: ?
avatar infograf768 infograf768 - change - 19 Dec 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-12-19 07:26:11
Closed_By infograf768
avatar infograf768 infograf768 - close - 19 Dec 2019
avatar infograf768 infograf768 - merge - 19 Dec 2019
avatar infograf768
infograf768 - comment - 19 Dec 2019

tks

Add a Comment

Login with GitHub to post a comment