I have tested this item ✅ successfully on 5b27520

I have tested this item ✅ successfully on 5b27520

RTC

@HLeithner Can you please merge as checks constantly failed? Thanks.

The test has to fail because this pr changes the markup and the test can't press the button anylonger...

So whats the reason to change this from span to button? and shouldn't the joomla-toolbar-button simulate button @ggppdk or what do I miss?

This PR changes the markup to be consistent with other toolbar buttons in order to display the hover cursor as a hand and not an arrow.

Then the test has to be adapted... shouldn't be too hard but don't have time to look at it sorry maybe @Hackwar can have a look?

These failures can't be related to any changes here

[Selenium browser Logs]
--
666 | 00:24:47.537 SEVERE - http://localhost/test-install/media/layouts/js/joomla/html/batch/batch-language.min.js?6d89747421e0b9c3cc781287dd5b01dd 0:391 Uncaught TypeError: Cannot read property 'addEventListener' of undefined
667 | 00:24:48.192 SEVERE - http://localhost/test-install/media/layouts/js/joomla/html/batch/batch-language.min.js?6d89747421e0b9c3cc781287dd5b01dd 0:391 Uncaught TypeError: Cannot read property 'addEventListener' of undefined
668 | 00:24:53.810 SEVERE - http://localhost/test-install/media/layouts/js/joomla/html/batch/batch-language.min.js?6d89747421e0b9c3cc781287dd5b01dd 0:391 Uncaught TypeError: Cannot read property 'addEventListener' of undefined

Hopefully the tests are now updated correctly and will pass

My attempt at guessing the fix to the tests failed. @puneet0191 @Hackwar any help greatly appreciated. PS it does seem odd that the test named uploading files seems to be all about deleting files

I can confirm the tests is replicating real life. If I click on the delete toolbar item and then click on delete again in the modal that appears. The item is not actually deleted.

my bad - you are right - this vue js is beyond me :(

The other buttons still work with this change and I just don't see the difference

The act of clicking the delete toolbar button is de-selecting the items. Not 100% sure why but I guess it's related to the active click area (or similar)

Hopefully it will pass the tests now

I think you still need the selector change too in the tests

@wilsonge it's still failing but with the usual timeout error - its not even getting as far as the relevant test. Dam these flaky tests are annoying

Woohoo - tests all pass now

Yay! Thanks!

thanks - got their in the end

got their

What have you done with the real Brian :P

he is teaching me to spell