? Pending

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
13 Dec 2019

With #19353 we added support for non-prefixed language files into J3.10. The loading behavior was set to keep loading prefixed files first so backward compatibility wasn't affected.
With #27130, the prefixed were removed from language files in 4.0.
Now this PR will change the loading order in 4.0 so non-prefixed files have priority over prefixed ones.

Summary of Changes

This PR changes the lookup order for language files so non-prefixed ones have precedence over prefixed ones.

Testing Instructions

Copy a language file (eg com_content.ini) and prefix the copy with the language code (eg en-GB.com_content.ini).
Now change a know string in there to a different value.

Expected result

The changed value will not be visible as com_content.ini is loaded first with this PR.

Actual result

The changed value will be used since currently the prefixed files is looked up first.

Documentation Changes Required

The change in default behavior should be noted if language file loading is documented anywhere.

avatar Bakual Bakual - open - 13 Dec 2019
avatar Bakual Bakual - change - 13 Dec 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Dec 2019
Category Administration com_languages Installation Libraries
avatar Bakual Bakual - change - 13 Dec 2019
The description was changed
avatar Bakual Bakual - edited - 13 Dec 2019
avatar Quy Quy - test_item - 13 Dec 2019 - Tested successfully
avatar Quy
Quy - comment - 13 Dec 2019

I have tested this item successfully on bc838c1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27250.

avatar infograf768 infograf768 - test_item - 14 Dec 2019 - Tested successfully
avatar infograf768
infograf768 - comment - 14 Dec 2019

I have tested this item successfully on bc838c1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27250.

avatar infograf768 infograf768 - change - 14 Dec 2019
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 14 Dec 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27250.

avatar infograf768 infograf768 - change - 14 Dec 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-12-14 09:24:29
Closed_By infograf768
Labels Added: ?
avatar infograf768 infograf768 - close - 14 Dec 2019
avatar infograf768 infograf768 - merge - 14 Dec 2019
avatar infograf768
infograf768 - comment - 14 Dec 2019

tks

Add a Comment

Login with GitHub to post a comment