?
avatar Bakual
Bakual
26 Nov 2019

Steps to reproduce the issue

Most of the language strings got changed so the singular form doesn't contain a variable anymore, as it will always contain the same value 1.
Search the language INI files for _1="% and you still get 20 matches. I guess those strings where missed.

Expected result

All singular form strings don't use a variable.

Actual result

Targets
    Occurrences of '_1="%' in Directory C:\Git\joomla-cms-org with mask '*.ini'
Found Occurrences  (20 usages found)
    Usage in string constants  (20 usages found)
        joomla-cms-org  (20 usages found)
            administrator\language\en-GB  (16 usages found)
                com_categories.ini  (2 usages found)
                    32 COM_CATEGORIES_HAS_SUBCATEGORY_ITEMS_1="%d item is assigned to one of this category's subcategories."
                    37 COM_CATEGORIES_N_ITEMS_ASSIGNED_1="%d item is assigned to this category."
                com_finder.ini  (7 usages found)
                    83 COM_FINDER_FILTERS_N_ITEMS_CHECKED_IN_1="%d filter checked in."
                    85 COM_FINDER_FILTERS_N_ITEMS_DELETED_1="%d filter deleted."
                    87 COM_FINDER_FILTERS_N_ITEMS_PUBLISHED_1="%d filter published."
                    89 COM_FINDER_FILTERS_N_ITEMS_UNPUBLISHED_1="%d filter unpublished."
                    159 COM_FINDER_MAPS_N_ITEMS_DELETED_1="%d map deleted."
                    161 COM_FINDER_MAPS_N_ITEMS_PUBLISHED_1="%d map published."
                    163 COM_FINDER_MAPS_N_ITEMS_UNPUBLISHED_1="%d map unpublished."
                com_installer.ini  (1 usage found)
                    120 COM_INSTALLER_MSG_DATABASE_ERRORS_1="%d Problem"
                com_privacy.ini  (1 usage found)
                    122 COM_PRIVACY_N_CONSENTS_INVALIDATED_1="%s consent was invalidated."
                com_tags.ini  (1 usage found)
                    64 COM_TAGS_HAS_SUBCATEGORY_ITEMS_1="%d item is assigned to one of this tag's subtags."
                lib_joomla.ini  (4 usages found)
                    416 JLIB_HTML_DATE_RELATIVE_DAYS_1="%s day ago."
                    419 JLIB_HTML_DATE_RELATIVE_HOURS_1="%s hour ago."
                    423 JLIB_HTML_DATE_RELATIVE_MINUTES_1="%s minute ago."
                    426 JLIB_HTML_DATE_RELATIVE_WEEKS_1="%s week ago."
            language\en-GB  (4 usages found)
                lib_joomla.ini  (4 usages found)
                    412 JLIB_HTML_DATE_RELATIVE_DAYS_1="%s day ago."
                    415 JLIB_HTML_DATE_RELATIVE_HOURS_1="%s hour ago."
                    419 JLIB_HTML_DATE_RELATIVE_MINUTES_1="%s minute ago."
                    422 JLIB_HTML_DATE_RELATIVE_WEEKS_1="%s week ago."

Additional comments

@brianteeman I think that's an easy one for you.

avatar Bakual Bakual - open - 26 Nov 2019
avatar joomla-cms-bot joomla-cms-bot - change - 26 Nov 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 26 Nov 2019
avatar Bakual Bakual - change - 26 Nov 2019
Title
4.0 Singular language string with variable
[4.0] Singular language string with variable
avatar Bakual Bakual - edited - 26 Nov 2019
avatar brianteeman
brianteeman - comment - 26 Nov 2019

Most of the language strings got changed so the singular form doesn't contain a variable anymore, as it will always contain the same value 1.

were they? not that i remember and a very quick grep only showed a few from com_users for the password thing

avatar brianteeman
brianteeman - comment - 26 Nov 2019

sorry bad search - ignore that - I will do a pr in the morning.

avatar alikon alikon - change - 27 Nov 2019
Status New Closed
Closed_Date 0000-00-00 00:00:00 2019-11-27 13:52:14
Closed_By alikon
avatar joomla-cms-bot joomla-cms-bot - change - 27 Nov 2019
Closed_By alikon joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 27 Nov 2019
avatar joomla-cms-bot
joomla-cms-bot - comment - 27 Nov 2019

Set to "closed" on behalf of @alikon by The JTracker Application at issues.joomla.org/joomla-cms/27160

avatar alikon
alikon - comment - 27 Nov 2019

please test #27170


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27160.

Add a Comment

Login with GitHub to post a comment