? ? Pending

User tests: Successful: Unsuccessful:

avatar ciar4n
ciar4n
24 Nov 2019

Pull Request for Issue #27119 .

Summary of Changes

Allows enabling of both 'High Contrast' & 'Monochrome'

Testing Instructions

Navigate to User Menu -> Accessibility Settings. Apply both Monochrome and High Contrast options.

Before PR

image

With PR

image

Documentation Changes Required

avatar ciar4n ciar4n - open - 24 Nov 2019
avatar ciar4n ciar4n - change - 24 Nov 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Nov 2019
Category Administration Templates (admin)
avatar ciar4n ciar4n - change - 24 Nov 2019
The description was changed
avatar ciar4n ciar4n - edited - 24 Nov 2019
avatar brianteeman
brianteeman - comment - 24 Nov 2019

as you have changed the contrast in the other pr to filter: contrast(115%); from filter: invert(100%); shouldnt you do the same here as well

avatar ciar4n
ciar4n - comment - 24 Nov 2019

If #27143 gets merged then I will amend this PR to match. Likewise, if this gets merged I will amend #27129. I notice multifaceted PRs tend to not get merged.

avatar ciar4n
ciar4n - comment - 24 Nov 2019

Eg. #26440

avatar brianteeman brianteeman - test_item - 24 Nov 2019 - Tested successfully
avatar brianteeman
brianteeman - comment - 24 Nov 2019

I have tested this item successfully on f4c4120


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27142.

avatar Quy Quy - test_item - 24 Nov 2019 - Tested successfully
avatar Quy
Quy - comment - 24 Nov 2019

I have tested this item successfully on f4c4120


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27142.

avatar Quy Quy - change - 24 Nov 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 24 Nov 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27142.

avatar wilsonge
wilsonge - comment - 25 Nov 2019

#27143 merged - happy to update this as mentioned?

avatar ciar4n ciar4n - change - 25 Nov 2019
Labels Added: ?
avatar ciar4n
ciar4n - comment - 25 Nov 2019

#27143 merged - happy to update this as mentioned?

Thank you. Updated.

avatar ciar4n ciar4n - change - 25 Nov 2019
Labels Added: ?
avatar wilsonge wilsonge - change - 25 Nov 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-11-25 11:41:37
Closed_By wilsonge
avatar wilsonge wilsonge - close - 25 Nov 2019
avatar wilsonge wilsonge - merge - 25 Nov 2019
avatar wilsonge
wilsonge - comment - 25 Nov 2019

Thanks!

avatar wilsonge
wilsonge - comment - 25 Nov 2019

Thanks!

Add a Comment

Login with GitHub to post a comment