[#27141] - [4.0] Move options from grid to column layout
- Fixed in Code Base
- 25 Nov 2019
- Medium
- Build: 4.0-dev
- # 27141
- Diff
- ciar4n:column-count
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #27136.
Summary of Changes
This PR creates some column-count classes and applies them to the joomla.edit.params layout.
Basically means that fields get ordered vertically (J3) instead of horizontally which is the case when using grid.
If this gets merged then I will apply on all other forms.
Testing Instructions
Apply this patch and run node build.js --compile-css for updating the changed SCSS. Alternatively, you can run npm i.
Navigate to article edit -> Options tab
Before PR
WIth PR
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) Layout |
Go to Content >Categories
Edit Uncategorised
Go to Options
Select is in the next column
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27141.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27141.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27141.
| Status | Ready to Commit | ⇒ | Pending |
Administrator Template Styles > autum > Image Settings
If this gets merged then I will apply on all other forms.
Is this related to my last comment?
The before and after look differently. Is this the expected behavior?
Is this related to my last comment?
There is another 60+ files that use the current grid based forms. A follow-up PR would apply the changes here across all such files and remove the old grid based forms CSS. The Atum XML from your last comment was created for the grid based forms so the field order was different. Most XMLs have been created with the column based forms used in Joomla 3 and therefore should be better suited to the changes here.
The before and after look differently. Is this the expected behavior?
Yes. There will be differences. Currently, forms are placed in a grid so forms are inline with each other both vertically and horizontally. This PR changes forms to a column layout.
Grid layout...
Column layout...
Look at any multi-column form outside of Joomla and they will always be in a column layout and read vertically, never a grid.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-11-25 11:08:24 |
| Closed_By | ⇒ | wilsonge |
Thank you for the tests.
That got merged two months ago?
THANK YOU