? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
22 Nov 2019

Summary of Changes

Removes obsolete JHtml path includes.

Testing Instructions

Code review.

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 22 Nov 2019
avatar SharkyKZ SharkyKZ - change - 22 Nov 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Nov 2019
Category Administration com_finder Modules Front End
avatar SharkyKZ SharkyKZ - change - 22 Nov 2019
Labels Added: ?
avatar Quy Quy - test_item - 22 Nov 2019 - Tested successfully
avatar Quy
Quy - comment - 22 Nov 2019

I have tested this item successfully on c53424c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27124.

avatar richard67
richard67 - comment - 23 Nov 2019

@SharkyKZ I'd really like to help with a good test, but I don't know how to see by code review if the removed code was obsolete or not. How do I have to check that?

avatar SharkyKZ
SharkyKZ - comment - 23 Nov 2019

@richard67 Need to check for two things. First that removed calls reference non-existing directories. And that HTML services are registered anyways. In components this is done automatically and elsewhere this can be done with application's bootComponent() method with the component specificed, e.g. like here

// Boot component to ensure HTML helpers are loaded
$app->bootComponent('com_privacy');
.

avatar richard67
richard67 - comment - 23 Nov 2019

@SharkyKZ Thanks for the help. I'll test later.

avatar richard67 richard67 - test_item - 24 Nov 2019 - Tested successfully
avatar richard67
richard67 - comment - 24 Nov 2019

I have tested this item successfully on c53424c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27124.

avatar richard67 richard67 - change - 24 Nov 2019
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 24 Nov 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27124.

avatar wilsonge wilsonge - change - 24 Nov 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-11-24 17:26:33
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 24 Nov 2019
avatar wilsonge wilsonge - merge - 24 Nov 2019
avatar wilsonge
wilsonge - comment - 24 Nov 2019

Thanks!

Add a Comment

Login with GitHub to post a comment