? ? Pending

User tests: Successful: Unsuccessful:

avatar viocassel
viocassel
21 Nov 2019

Pull Request for Issue # .

Summary of Changes

? Just some small cleanup...

Testing Instructions

Check if the extension is installed correctly using the drag and drop installer.

Expected result

The installer is working correctly.

Actual result

The installer is working correctly.

Documentation Changes Required

No

avatar viocassel viocassel - open - 21 Nov 2019
avatar viocassel viocassel - change - 21 Nov 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Nov 2019
Category Front End Plugins
avatar viocassel viocassel - change - 24 Nov 2019
Labels Added: ?
avatar Quy Quy - change - 5 Dec 2019
Title
Cleanup Insaller plugins
Cleanup Installer plugins
avatar Quy Quy - edited - 5 Dec 2019
avatar jwaisner jwaisner - test_item - 5 Jan 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 5 Jan 2020

I have tested this item successfully on 057b217


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27123.

avatar jwaisner jwaisner - change - 7 Apr 2020
Priority Medium Low
Easy No Yes
avatar Formatio-hippocampi Formatio-hippocampi - test_item - 8 Sep 2020 - Tested successfully
avatar Formatio-hippocampi
Formatio-hippocampi - comment - 8 Sep 2020

I have tested this item successfully on 057b217


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27123.

avatar Quy
Quy - comment - 16 Sep 2020

Please fix conflicting files.

avatar viocassel viocassel - change - 24 Sep 2020
Labels Added: Conflicting Files
avatar viocassel viocassel - change - 3 Oct 2020
Labels Removed: Conflicting Files
avatar Quy
Quy - comment - 22 Jan 2022

@zero-24 This PR is mainly coding style changes. Since the branch has been deleted, it is worth redoing? Should this be closed?

avatar zero-24
zero-24 - comment - 23 Jan 2022

Please do not understand me wrong but for now I would say when we have to redo it anyway target such cleanups against 4.1/4.2 rather than 3.10. Sure when we have topics like the php 8.1 adoption I'm happy to take it into 3.10 but such general cleanups often result into messy merge conflicts when merging 3.10 into 4.x. For the JS changes I'm not sure whether they are acutuall bug fixes when they are we should take them and target them against 3.10.

avatar laoneo
laoneo - comment - 25 Mar 2022

As stated above, the pr should be done against 4.2.

avatar laoneo laoneo - change - 25 Mar 2022
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2022-03-25 18:02:53
Closed_By laoneo
Labels Added: ? ?
Removed: ?
avatar laoneo laoneo - close - 25 Mar 2022

Add a Comment

Login with GitHub to post a comment