[#27099] - [4.0] Select Client/Administrator filter [a11y]
- Fixed in Code Base
- 25 Nov 2019
- Medium
- Build: 4.0-dev
- # 27099
- Diff
- brianteeman:menu
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
The labels for some of these fields was missing or not being used due to the layout. In addition the labels have been standardised to "Select Client" which is more in keeping with other similar labels.
To test you will need to apply the patch and then view the source code to see that all these filters have an sr-only label of Select Client
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus com_modules com_templates Language & Strings |
If we're standardising everything to Select Client doesn't it make more sense to normalise them to a global language string rather than setting them per component here
It can be if you want
Should keep translators lives a bit easier than 3 dupes. It's not totally outlandish to think it might have uses in fields etc too for frontend/backend form editing etc. so yeah lets go with it
| Labels |
Added:
?
?
|
||
| Category | Administration com_menus com_modules com_templates Language & Strings | ⇒ | Administration com_languages com_menus com_modules Language & Strings |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27099.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27099.
| Status | Pending | ⇒ | Ready to Commit |
rtc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27099.
Apparently this branch is out-of-date but I can't update it.
| Labels |
Added:
?
|
||
@brianteeman can you fix conflicts please
conflicts resolved
This works but I still can't update the branch and therefore can't merge this PR.
- Unless there are conflicts there is no need to update a branch before you can merge it
- I deliberately set my branch so that it could not be updated by others
Then "ordinary" maintainers are not able to merge your stuff as "Squash and Merge" is not available.
so be it
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-11-25 13:37:14 |
| Closed_By | ⇒ | wilsonge |
Thanks!
Thanks
I have tested this item✅ successfully on 57562c9
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27099.