I have tested this item ✅ successfully on f17349d

Toggled Site Offline. configuration.php > public $offline=true;

I have tested this item ✅ successfully on f17349d

Toggled Site Offline. configuration.php > public $offline=true;

I have tested this item ✅ successfully on f17349d

Working fine as per the mentioned "Testing instructions".

RTC.

@HLeithner
is that OK for you?

I'm still not sure if this is the proper way to do this. But yeah if it's the best solution to resolve the problem. Shouldn't this be done in the model/formfield layer and not in the layout?

Forget my comment I mixed 2 pr's it seams to be ok.

In this specific case wondering if we actually should have this in the form. normally this is correct. However in the normal (non-switcher) radio field it may not be.

It is working now for switcher and non-switcher.

Changing this in the Jformfield would mean that this is valid for all abstracted classes, that means if I have a input field I get a '0' instead of an empty string correct? (if the function is not overridden)

I wouldn't expect this.

It is checking for a false value. Empty string does not apply.
To test, apply PR. See Path to Cache Folder field where it is empty. It does not display 0.

thats true but if the value is false it would convert it also for a text field into '0' and not ''

It is a strict comparison for boolean and false. A string value will not be affected.

@Quy
You mean that when we have:

			<option value="true">JYES</option>
			<option value="false">JNO</option> 

It would have no impact?

I am not at a computer to test but it should not be affected because it is string and not boolean.

Also this applies to the configuration file only when storing true/false values if I am not wrong. It has been a while since doing this PR. My memory not so good these days.

I wounder how it may have RTC 😉

Doing if ($this->value === false) globally in FormField is incorrect, it will affect every field.

That maybe better to do after #27202 will be merged

Works perfectly for me. I dont see any issues.

@Fedik please post exactly where it breaks

Works perfectly for me. I dont see any issues.

@Fedik please post exactly where it breaks

I have tested this item ✅ successfully on 72e779b

I can't comment about the code but it solves the problem

please post exactly where it breaks

People tested it with switcher field, but this changes:

will affect every field

this may lead to unexpected behavior, when example some extension have a custom field,
which expect value to be boolean false, and we force it to be string '0'.

Took off RTC until @Fedik comment is taken care of.

setting to pending

@Fedik could you please provide a specific example

I do not have a specific example to demonstrate, it a logic assumption that comes from the code review.

If we need this hacky thing, then better to do it specifically for the switcher field, not global.

There a couple ways:
Or move this hacky code to the switcher layout itself layouts/joomla/form/field/radio/switcher.php
Or fix these two conditions to work correctly:

Is this better?

much better 😉

I mean it's grim. But much better than the initial code change. So merging. Thankyou!