[#27055] - calendar field not triggering onchange after clear button pressed
- Fixed in Code Base
- 5 Dec 2019
- Medium
- Build: staging
- # 27055
- Diff
- hikashop-nicolas:staging
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #27054 .
Summary of Changes
We add the trigger to the onchange event after clearing the input field when the "clear" button is pressed.
Testing Instructions
install HikaShop Starter
go to Components->HikaShop->Orders
select a date in one of the calendar field on the top right of the listing
the page is refreshed with the calendar field selected date set
click on the "clear" button of that calendar field
Expected result
the value is cleared and the page is refreshed with the calendar field empty
Actual result
the value is cleared and the page is not refreshed
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript |
| Labels |
Added:
?
|
||
Thank you for your feedback. I've added a check to call onchange only when defined. That will prevent the javascript error when the onchange is not defined, like on the Joomla article edition page.
It's done
I have tested this item
Also can be tested here: Components > Banners > Tracks > Search Tools
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27055.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27055.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27055.
| Labels |
Added:
?
|
||
Thanks for the for fix.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-12-05 22:38:20 |
| Closed_By | ⇒ | HLeithner |
@hikashop-nicolas Can you please check the minified file as the calendar is not displaying?
SyntaxError: expected expression, got keyword 'if' calendar.min.js:1:15600
Edit an article.
Clear
Start Publishing.See in Console.