Feeling Lucky
?
?
[#26883] - [mod_banners] - tooltip text
- Fixed in Code Base
- 4 Nov 2019
- Medium
- Build: staging
- # 26883
- Diff
- alikon:patch-112
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Language & Strings |
| Title |
|
||||||
brianteeman
- comment
- 1 Nov 2019
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26883.
brianteeman
- comment
- 1 Nov 2019
you are both correct. As this is such a stupid illogical function I think this proposal is the one that provides the greater clarity
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26883.
richard67
- comment
- 1 Nov 2019
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26883.
| Labels |
Added:
?
|
||
richard67
- comment
- 1 Nov 2019
RTC.
richard67
- comment
- 1 Nov 2019
Why does that bot now remove the language change label?
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 1 Nov 2019
not sure... i think the issue bot just only need a bit of care
richard67
- comment
- 1 Nov 2019
Bot needs care? You mean I should offer him (or her?) a beer or give him/her a massage?
priyankaSahutekdi
- comment
- 2 Nov 2019
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26883.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-11-04 18:40:47 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 4 Nov 2019
Thanks!
@brianteeman Could you have a look on the changed text? From my point of view the change made by this PR is 100% correct. But my English teachers would have said that it could be simplified, avoiding repeating the "meta keywords". Maybe something like "Banner is selected by matching its meta keywords to those of the current document."?