[#26882] - Fixed "answer provided by user" issue on reCAPTCHA
- Fixed in Code Base
- 25 Dec 2019
- Medium
- Build: staging
- # 26882
- Diff
- rifatwahid:staging
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
"answer provided by user" issue on reCAPTCHA, Specially it's conflicting if multiple reCAPTCHA found on the respective page.
Summary of Changes
Worked on "onCheckAnswer" function. The "$code" parameter's value wasn't implementing inside the function. While you call "onCheckAnswer" function, it used to take "response" from the form which was conflicting if multiple reCAPTCHA found on the respective page.
Testing Instructions
Create multiple contact forms in one page with reCAPTCHA (it should be ajax contact form, We tested by SP Page Builder) and submit the second or third form with complete reCAPTCHA.
Expected result
if anyone sends any value to "$code" parameter on "onCheckAnswer" function, it should take the "$code" parameter's value "$code" as "response".
Actual result
Worked on "onCheckAnswer" function. The "$code" parameter's value wasn't implementing inside the function. While you call "onCheckAnswer" function, it used to take "response" from the form which was conflicting if multiple reCAPTCHA found on the respective page.
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Labels |
Added:
?
|
||
Are there any free extensions to test this with? Contact forms are only in Pro version of SP Page Builder.
Thanks for the test. I can provide you the SP Page Builder pro privately for test with it.
OK, send it to sharkykz@gmail.com please. And could you implement code simplifications suggested above. Thanks.
OK, send it to sharkykz@gmail.com please. And could you implement code simplifications suggested above. Thanks.
I have send you a SP Page Builder copy. Thanks.
Thanks. PR works fine. Just please update it according to code suggestions above.
is everything ok now, please? Please note, the same issue exists in the invisible reCaptcha also. will I request a pull again? or you can add the code?
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-12-25 07:51:15 |
| Closed_By | ⇒ | HLeithner |
Thanks for fixing this bug.
Hi HLeithner,
You are always welcome, The same issue exists in the invisible reCaptcha aswell, Will I request a pull again as like this again? or, you guys will fix it?
- Thanks
@rifatwahid please provide a pull request. Because "you guys" means also you ;-)
I have tested this item✅ successfully on f7f7291
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26882.