[#26811] - [4.0] [com_banners] Prepared statements (frontend)
- Fixed in Code Base
- 25 Oct 2019
- Medium
- Build: 4.0-dev
- # 26811
- Diff
- SharkyKZ:j4/prepared/com_banners
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
This adds prepared statements and cleans up queries in com_banners frontend.
Testing Instructions
Create some banners.
Publish some banner modules.
Browse around frontend.
Click on some banners.
In backend check that banner statistics (impressions and clicks) are still tracked correctly.
Expected result
Works like before.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_banners |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-10-25 06:12:54 |
| Closed_By | ⇒ | SharkyKZ | |
| Labels |
Added:
?
|
||
| Status | Closed | ⇒ | New |
| Closed_Date | 2019-10-25 06:12:54 | ⇒ | |
| Closed_By | SharkyKZ | ⇒ |
| Status | New | ⇒ | Pending |
| Category | Front End com_banners | ⇒ | Front End com_banners Modules |
| Category | Front End com_banners Modules | ⇒ | Front End com_banners |
I've added a third banner and I realize that all three are displayed at the same time, even with the "pinned, randomize" option of the module?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26811.
That is correct. Set "Count" option to 1 if you want to display one banner at a time.
Oh sorry, the test is now ok. Thank you
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26811.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26811.
Nice
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26811.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26811.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26811.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-10-25 22:05:00 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
I have tested this item✅ successfully on 24e7ede
The patch now displays the number of clicks correctly. But I created two banners, and when I click one, Total print displays an impression for each banner when there is only one that has been displayed.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26811.