[#26810] - Fixing validation of emails by changing 'error-handling' in EmailRule.php (related to 26637)
- Fixed in Code Base
- 3 Nov 2019
- Medium
- Build: 4.0-dev
- # 26810
- Diff
- datsepp:4.0-dev-invalid-email-test
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #26637.
Summary of Changes
Good evening/night. I wanted to go to bed 2 or 3 hours ago, now I am here.
I started to work on the issue #26637. First of all I thought it's just a small change in the request.xml of the com_privacy module, until I determine that this wasn't the case.
After switching from class to class I got into the validate() method of the FormModel, afterwards into the validate() method of FormField. Here I found the 'testing' rules part which got packed into a try catch block.
Tl;dr in conclusion: I changed return statements to throw statements in the EmailRule for fitting into the try catch block of FormField.php, which catches these exceptions. Other rules are doing that as well as far as I could observe.
Testing Instructions
Thats the awesome part: It's working everywhere, where you have to test if an email address is valid.
You can test it like this (#26637 ):
- open your admin control panel
- navigate to
users->privacy->requests - press
newon the top left - enter a non valid e-mail address
- save&close it.
Expected result
Documentation Changes Required
I added a throw paragraph. Hope that's enough for that.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26810.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26810.
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26810.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26810.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-11-03 00:43:53 |
| Closed_By | ⇒ | wilsonge |
Thanks!
I have tested this item✅ successfully on 71b13d9
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26810.