? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
24 Oct 2019

The color used for <code> is $pink which was failing accessibility contrast checks. This PR tweaks the colour so it doesn't fail.

Spotted this while testing #26744 which wraps the download key in <code>

avatar brianteeman brianteeman - open - 24 Oct 2019
avatar brianteeman brianteeman - change - 24 Oct 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Oct 2019
Category Administration Templates (admin)
avatar Quy Quy - test_item - 24 Oct 2019 - Tested successfully
avatar Quy
Quy - comment - 24 Oct 2019

I have tested this item successfully on a2f40c2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26808.

avatar richard67 richard67 - test_item - 25 Oct 2019 - Tested successfully
avatar richard67
richard67 - comment - 25 Oct 2019

I have tested this item successfully on a2f40c2

With good will it still can be considered to be some kind of pink ;-)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26808.

avatar Quy Quy - change - 25 Oct 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 25 Oct 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26808.

avatar wilsonge wilsonge - change - 25 Oct 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-10-25 20:51:49
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 25 Oct 2019
avatar wilsonge wilsonge - merge - 25 Oct 2019
avatar wilsonge
wilsonge - comment - 25 Oct 2019

Thanks!

avatar brianteeman
brianteeman - comment - 25 Oct 2019

Thanks

Add a Comment

Login with GitHub to post a comment