? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
24 Oct 2019

Pull Request for Issue #26713 .

Summary of Changes

use the ?? (Null Coalescing Operator) to get 1 instead of ""
redo of #25949

Testing Instructions

create an admin using Import a preset "Preset - Joomla Main Menu".

Expected result

able to create admin menu

Actual result

SQL ERROR:

avatar alikon alikon - open - 24 Oct 2019
avatar alikon alikon - change - 24 Oct 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Oct 2019
Category Administration com_menus
avatar SharkyKZ
SharkyKZ - comment - 24 Oct 2019

I don't think ID should be hardcoded. There's Joomla\CMS\Table\Nested::getRootId() method for getting root item ID.

avatar alikon
alikon - comment - 24 Oct 2019

correct, make perfect sense

avatar alikon alikon - change - 24 Oct 2019
Labels Added: ?
avatar richard67 richard67 - test_item - 24 Oct 2019 - Tested successfully
avatar richard67
richard67 - comment - 24 Oct 2019

I have tested this item successfully on 180335d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26807.

avatar richard67
richard67 - comment - 24 Oct 2019

@waader Please test. Thanks in advance.

avatar waader
waader - comment - 25 Oct 2019

@richard67: I tested with postgresql and after selecting "Preset - Joomla Main Menu" no menu items where inserted.

avatar richard67
richard67 - comment - 25 Oct 2019

Hmm, I had postgresql, too, have it for testing such PRs .. for me it worked .. strange. I have version 10.10. Does your postgresql log show any errors? On my Ubuntu Linux it is /var/log/postgresql/postgresql-10-main.log. On other OS, at least the file name should be similar.

avatar waader
waader - comment - 30 Oct 2019

There is no error in the postgresql log and a look in _menu shows that records are inserted.

avatar richard67
richard67 - comment - 30 Oct 2019

@waader So they are just not visible in the menu in backend, but in database the new records are there? @alikon Could that be a problem with nested table, lft and rgt?

avatar waader
waader - comment - 30 Oct 2019

@richard67 Correct!

avatar alikon alikon - change - 12 Feb 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-02-12 19:34:44
Closed_By alikon
avatar alikon alikon - close - 12 Feb 2020

Add a Comment

Login with GitHub to post a comment