[#26778] - [4.0] Installation languages model install articles with real null value for publish down time
- Closed
- 26 Oct 2019
- Medium
- Build: 4.0-dev
- # 26778
- Diff
- richard67:4.0-dev-null-datetimes-install-languages
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This is a follow up to recently merged PR's which changed datetime columns in database for real null values.
It makes sure that the addArticle routine in file installation/src/Model/LanguagesModel.php does not add any article with an old fashioned null value (which might be invalid on newer versions of MySQL databases depending on server and session settings) for any datetime column in database.
Testing Instructions
Code review should be enoug: Check that in the file modified by this PR there is no other place where an old fashioned null datetime is written to database.
Expected result
No old fashioned null datetime is written to database.
Actual result
Old fashioned null datetime is written to database for the published down time of articles.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Installation |
| Title |
|
||||||
| Labels |
Added:
?
|
||
Folks, most of this file has to be deleted as we do not propose anymore setting multilang during installation but only through the Multilingual Sample Data plugin.
Therefore the addArticle method is obsolete as many of the methods there.
@infograf768 Which other functions are obsolete? Should I make a new PR to remove all unused stuff from this file and close this PR here?
Should I make a new PR to remove all unused stuff from this file and close this PR here?
yep.
To find out which methods are definitely obsolete, I suggest to compare the methods used in the multilang sample data plugin (as I originally copied the ones from LanguagesModel) and the methods in this LanguagesModel.
It should concern all the methods from private function enablePlugin($pluginName) line 485 and after in the plugin.
@infograf768 Thanks, I'll do that later.
Closing for reasons stated above: #26778 (comment).
New PR to remove obsolete multilingual installation stuff will come.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-10-26 08:38:10 |
| Closed_By | ⇒ | richard67 |
no problem at all ....it's always better to have different eyes looking at things
I have tested this item✅ successfully on 71229eb
LGTM
code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26778.