[#26777] - [4.0] [com_contenthistory] Add check for real null datetimes
- Fixed in Code Base
- 3 Nov 2019
- Medium
- Build: 4.0-dev
- # 26777
- Diff
- richard67:4.0-dev-com-contenthistory-null-date
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This is a follow up to recently merged PR's which changed datetime columns in database for real null values.
Because content history might be used not only for core components' database tables, the checks for the old (preudo-)null datetimes are kept and extended by the check for real null values.
The PR makes sure that in the comparison and preview models, no datetime formatting is done with null values.
Testing Instructions
Code review should be sufficient: Make sure that in com_contenthistory there are no other places where old (preudo-)null datetimes are checked without checking for real null values, too.
Expected result
Datetime values which have real null values in database are shown as emtpy and not as any rubbish date.
Actual result
Datetime values which have real null values in database might be shown as some rubbish date or lead to formatting errors.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content com_contenthistory |
| Title |
|
||||||
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26777.
I have tested this item
By review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26777.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26777.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-11-03 00:43:12 |
| Closed_By | ⇒ | wilsonge |
Thanks!
Thanks too.
Drone failure seems to be unrelated.