Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#26757] - [4.0] Revert #26056, solving dropdown batch icon and add module icon

NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
22 Oct 2019

Pull Request for Issue #26741

Summary of Changes

Reverts #26056
Changed fa fa-square to icon-square to solve that batch dropdown icon display issue. THanks @Quy :)
Correct alignment of the Dashboard add module

Testing Instructions

Patch. Run npm.
Display /administrator/index.php and ckeck quickicons alignment are correctly centered as well as the Add module to the dashboard icon.

Display the Content Dashboard and check the alignment of the + icon

Display the Article manager, select an article and check the alignment of the Batch icon.

Before patch

See #26741

After patch

Screen Shot 2019-10-22 at 08 14 36

Screen Shot 2019-10-22 at 08 15 54

Screen Shot 2019-10-22 at 08 15 04

Screen Shot 2019-10-22 at 08 16 22

avatar infograf768 infograf768 - open - 22 Oct 2019
avatar infograf768 infograf768 - change - 22 Oct 2019
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Oct 2019
Category ⇒ Administration Templates (admin) Repository NPM Change Libraries
avatar C-Lodder
C-Lodder - comment - 22 Oct 2019

Ideally you want to start moving all core to the fa class (seeing as svg's won't be accepted). The fa and icon classes should adopt the same CSS (as they are simply mapped rather than a different font set), so there should be no difference between the classes.

I'd suggest finding and properly fixing the core root of the actual problem rather than trying to cover it up

avatar infograf768
infograf768 - comment - 22 Oct 2019

@C-Lodder
I agree this would be ideal.
I also think it has to be done in a specific PR and I have no idea how to do that.
In the mean while let's just have things work as should as #26056 broke all and I can't make RTL corrections without it.

avatar infograf768 infograf768 - change - 22 Oct 2019
The description was changed
avatar infograf768 infograf768 - edited - 22 Oct 2019
avatar Quy Quy - test_item - 22 Oct 2019 - Tested successfully
avatar Quy
Quy - comment - 22 Oct 2019

I have tested this item ✅ successfully on 30aee16

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26757.

avatar richard67 richard67 - test_item - 22 Oct 2019 - Tested successfully
avatar richard67
richard67 - comment - 22 Oct 2019

I have tested this item ✅ successfully on 30aee16

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26757.

avatar Quy Quy - change - 22 Oct 2019
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 22 Oct 2019

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26757.

avatar infograf768 infograf768 - change - 23 Oct 2019
Labels Added: ?
avatar infograf768 infograf768 - change - 23 Oct 2019
Labels Added: NPM Resource Changed ?
avatar Quy Quy - change - 23 Oct 2019
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-10-23 13:54:23
Closed_By ⇒ Quy
avatar Quy Quy - close - 23 Oct 2019
avatar Quy Quy - merge - 23 Oct 2019

Add a Comment

Login with GitHub to post a comment