[#26756] - [4.0] Null date corrections for frontent edit icon
- Fixed in Code Base
- 25 Oct 2019
- Medium
- Build: 4.0-dev
- # 26756
- Diff
- richard67:4.0-dev-edit-icon-nulldates
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #26783 , see also #26751 (comment) .
Summary of Changes
Changes the code to produce the edit icon for frontend editing so it handles real null values for published up and down times.
This fixes the issue that on current 4.0-dev, they eye icon is shown for published articles instead of the edit icon, like it would be with unpublished or not published yet articles.
Testing Instructions
Use an installation of current 4.0-dev or latest nightly build of today.
- Create an article with state = published and show it on frontend.
- On frontend, login as used who has permission for frontend editing.
- Click the edit button (gear icon at the right top corner of article).
- In the pulldown which appears below the gear icon, check the icon shown for the "Edit" menu item.
Result: See section "Actual result" below.
- Apply patch.
- Reload the page on frontend.
- Check again the icon in the frontend editing pulldown menu.
Result: See section "Expected result" below.
- Play around with publish up and down times so you have following situations, and check the icon again:
- Published down in past = article expired
- Published up in future = article pending (i.e. not published yet)
- Published up in past, published down in future = article published
- If you want play with other combinations with empty or not empty published up or down fields.
Expected result
For published articles the edit icon is shown and for unpublished, pending or expired articles the eye icon.
Actual result
For published articles the same eye icon is shown as for unpublished, expired or pending articles.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
| Title |
|
||||||
In pull 26751 @ infograf768 it says: Null Date is now defined by null and no more by Factory :: getDbo () -> getNullDate ()
Now in this pull it is used again ... Am I missing something or is there something I don't understand?
Or the problem is that there is no established parameter of code ?, as it still happens with the array limes () and that they should be replaced by [] but still use them in the development of Joomla 4.x ... as as many deprecated that are still written.
Thank you.
@Stuartemk We want to keep the old nulldates in addition to real nulls only where it might be necessary for 3rd party extensions. Here I am not sure if to keep it or not, that's why I've pinged wilsonge before for his opinion.
Or shall we better stay safe and keep the old nulldates like it is now in this PR?
That layout can be used by a 3rd party. Let's keep the old nulldates.
| Labels |
Added:
?
|
||
I get with this patch depending on the state of the article:
and
Is that OK? (Except evidently for the display of the tips)
@infograf768 Yes, that’s how it shall be (except the bad tips of course).
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26756.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26756.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26756.
Or shall we better stay safe and keep the old nulldates like it is now in this PR?
No. This layout is specific to com_content.
George confirmed in Glip that I shall keep the old nulldates, too, because this layout might be used by 3rd partries, too, and I think if not then it doesn't hurt. Naming of variables and so on look to me as if it was made for articles only, but this might be for historic reasons because frontend editing at the very first beginning was limited to articles only, if I remeber right. So all ok here.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-10-25 20:47:57 |
| Closed_By | ⇒ | wilsonge |
Thanks!
Thanks too all testers and mergers
@wilsonge Do we need to check old nulldates here for 3rd party compatibility? Is not a library, but can the layout used by 3rd party? As far as I can it is only made for articles, and those are created by core, so we don't need to check old nulldates, right? Or shall we better stay safe and keep the old nulldates like it is now in this PR?