Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#26743] - [4.0] Webcomponents JS not found

NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
20 Oct 2019

Pull Request for Issue # .

Summary of Changes

Corrects filename.

Testing Instructions

Use a browser that requires WC polyfills, e.g. Edge.

Expected result

Everything works.

Actual result

Some buttons and other elements are broken due to JS errors:

Error: Could not load polyfill bundlehttp://localhost/joomla-cms/media/vendor/webcomponentsjs/js/webcomponents-sd.min.js
core.js:1058:17
GET
http://localhost/joomla-cms/media/vendor/webcomponentsjs/js/webcomponents-sd.min.js [HTTP/1.1 404 Not Found 5ms]
Error: Could not load polyfill bundle http://localhost/joomla-cms/media/vendor/webcomponentsjs/js/webcomponents-sd.min.js
core.js:1058:17

Documentation Changes Required

avatar SharkyKZ SharkyKZ - open - 20 Oct 2019
avatar SharkyKZ SharkyKZ - change - 20 Oct 2019
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Oct 2019
Category ⇒ JavaScript Repository NPM Change
avatar SharkyKZ SharkyKZ - change - 20 Oct 2019
The description was changed
avatar SharkyKZ SharkyKZ - edited - 20 Oct 2019
avatar SharkyKZ SharkyKZ - change - 20 Oct 2019
The description was changed
avatar SharkyKZ SharkyKZ - edited - 20 Oct 2019
avatar SharkyKZ SharkyKZ - change - 20 Oct 2019
The description was changed
avatar SharkyKZ SharkyKZ - edited - 20 Oct 2019
avatar Quy Quy - test_item - 20 Oct 2019 - Tested successfully
avatar Quy
Quy - comment - 20 Oct 2019

I have tested this item ✅ successfully on 3c51034

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26743.

avatar anibalsanchez anibalsanchez - test_item - 20 Oct 2019 - Tested successfully
avatar anibalsanchez
anibalsanchez - comment - 20 Oct 2019

I have tested this item ✅ successfully on 3c51034

It goes to the right files now.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26743.

avatar SharkyKZ SharkyKZ - change - 20 Oct 2019
Status Pending ⇒ Ready to Commit
Labels Added: ? NPM Resource Changed
avatar SharkyKZ
SharkyKZ - comment - 20 Oct 2019

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26743.

avatar wilsonge
wilsonge - comment - 21 Oct 2019

OK on my macbook the minifed file here exists (In terms of this path media/vendor/webcomponentsjs/js/webcomponents-sd.min.js)
Screenshot 2019-10-21 at 09 56 15

Why is the minified file not existing for you I think is the question here

avatar wilsonge wilsonge - change - 21 Oct 2019
Status Ready to Commit ⇒ Information Required
avatar SharkyKZ
SharkyKZ - comment - 21 Oct 2019

You probably need to run npm ci. Those files are not included in nightlies anyways. I think since #26557.

avatar dgrammatiko
dgrammatiko - comment - 21 Oct 2019

@SharkyKZ if so then there should be a bug in this line https://github.com/joomla/joomla-cms/pull/26557/files#diff-788d2ec61f82f93e185ade0fdbd27898R23

avatar SharkyKZ SharkyKZ - change - 21 Oct 2019
Labels
avatar SharkyKZ
SharkyKZ - comment - 21 Oct 2019

And here I thought this was intentional ?

avatar Quy Quy - test_item - 21 Oct 2019 - Tested successfully
avatar Quy
Quy - comment - 21 Oct 2019

I have tested this item ✅ successfully on ce72964

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26743.

avatar wilsonge wilsonge - change - 21 Oct 2019
Status Information Required ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-10-21 20:41:17
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 21 Oct 2019
avatar wilsonge wilsonge - merge - 21 Oct 2019
avatar wilsonge
wilsonge - comment - 21 Oct 2019

Thanks! Looks better now!

Add a Comment

Login with GitHub to post a comment