[#26618] - [4.0] Re enable some muted code in Finder
- Fixed in Code Base
- 19 Oct 2019
- Medium
- Build: 4.0-dev
- # 26618
- Diff
- dgrammatiko:4.0-dev-com_finder
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- Remove a global var, whoever did this is not my friend (hint: probably I did it)
- Unmute some code that was closing automatically a modal
Note: The Joomla.Modal API is always on the parent window!!!
(eg if there is an iframe and you need to call it from there you must call it like: window.parent.Joomla.Modal.getCurrent().close())
Testing Instructions
Run npm install !important
Go to http://j4.local/administrator/index.php?option=com_finder&view=index
click on the Index button
The modal SHOULD close automatically at the end of the indexing process
Expected result
Actual result
Documentation Changes Required
No, cleanup
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder JavaScript Repository NPM Change |
The last message flashes quickly as the modal closes. Is this the desired behavior?
Might be the globally applied animations, I didn't notice to be honest...
I have tested this item
Tested this issue
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26618.
I have tested this item
Tested uncessessfully.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26618.
I have tested this item
it is not closing after the indexing is completed but if we hit the window.parent.Joomla.Modal.getCurrent().close() in console it gets closed.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26618.
| Labels |
Added:
NPM Resource Changed
?
|
||
I have tested this item
I had applied the patch:
I can confirm the expected results.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26618.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26618.
I have tested this item
Modal closes after index finished.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26618.
Merging. But we should keep an eye on the animations I guess
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-10-19 15:40:44 |
| Closed_By | ⇒ | wilsonge |
The last message flashes quickly as the modal closes. Is this the desired behavior?